diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2024-02-28 10:38:26 +0100 |
|---|---|---|
| committer |   Lee Jones <lee@kernel.org> | 2024-03-07 08:48:14 +0000 |
| commit | 08b7dab9f025e20dc02bb4ad19b8e519c3948d20 (patch) | |
| tree | 944392cc6fb176cf7ef61daf6de7517c6fdd761e /include/linux/leds.h | |
| parent | dt-bindings: leds: qcom-lpg: Narrow nvmem for other variants (diff) | |
| download | wireguard-linux-08b7dab9f025e20dc02bb4ad19b8e519c3948d20.tar.xz wireguard-linux-08b7dab9f025e20dc02bb4ad19b8e519c3948d20.zip | |
leds: Fix ifdef check for gpio_led_register_device()
gpio_led_register_device() is built whenever CONFIG_LEDS_GPIO_REGISTER is
enabled, and this may be used even when CONFIG_NEW_LEDS is turned off.
However, the stub declaration in the header is provided for all configs
without CONFIG_NEW_LEDS, resulting in a build failure:
drivers/leds/leds-gpio-register.c:24:1: error: redefinition of 'gpio_led_register_device'
24 | gpio_led_register_device(int id, const struct gpio_led_platform_data *pdata)
| ^
include/linux/leds.h:646:39: note: previous definition is here
Change the #ifdef check to match the definition.
Note: this apparently took years of randconfig builds to hit, since
a number of other drivers just 'select NEW_LEDS' anyway.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240228093834.2230004-1-arnd@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'include/linux/leds.h')
| -rw-r--r-- | include/linux/leds.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/leds.h b/include/linux/leds.h index 7598d472903a..db6b114bb3d9 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -639,7 +639,7 @@ struct gpio_led_platform_data { gpio_blink_set_t gpio_blink_set; }; -#ifdef CONFIG_NEW_LEDS +#ifdef CONFIG_LEDS_GPIO_REGISTER struct platform_device *gpio_led_register_device( int id, const struct gpio_led_platform_data *pdata); #else |