diff options
| author |   Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2023-04-17 12:26:52 +0300 |
|---|---|---|
| committer |   Lee Jones <lee@kernel.org> | 2023-06-15 09:19:36 +0100 |
| commit | e9c154eed8aa166330eb0a8dc84642a8675c31e6 (patch) | |
| tree | 6220299f40119e4a8c969636373f17c9e3cd7709 /include/linux/mfd | |
| parent | mfd: intel-m10-bmc: Create m10bmc_sys_update_bits() (diff) | |
| download | wireguard-linux-e9c154eed8aa166330eb0a8dc84642a8675c31e6.tar.xz wireguard-linux-e9c154eed8aa166330eb0a8dc84642a8675c31e6.zip | |
mfd: intel-m10-bmc: Move m10bmc_sys_read() away from header
Move m10bmc_sys_read() out from the header to prepare it for adding
more code into the function which would make it too large to be a
static inline any more.
While at it, replace the vague wording in function comment with more
precise statements.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Guenter Roeck <linux@roeck-us.net> # For hwmon
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230417092653.16487-4-ilpo.jarvinen@linux.intel.com
Diffstat (limited to 'include/linux/mfd')
| -rw-r--r-- | include/linux/mfd/intel-m10-bmc.h | 17 |
1 files changed, 1 insertions, 16 deletions
diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h index 5418f7279ed0..252644fa61be 100644 --- a/include/linux/mfd/intel-m10-bmc.h +++ b/include/linux/mfd/intel-m10-bmc.h @@ -267,22 +267,7 @@ m10bmc_raw_read(struct intel_m10bmc *m10bmc, unsigned int addr, return ret; } -/* - * The base of the system registers could be configured by HW developers, and - * in HW SPEC, the base is not added to the addresses of the system registers. - * - * This function helps to simplify the accessing of the system registers. And if - * the base is reconfigured in HW, SW developers could simply change the - * csr_map's base accordingly. - */ -static inline int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset, - unsigned int *val) -{ - const struct m10bmc_csr_map *csr_map = m10bmc->info->csr_map; - - return m10bmc_raw_read(m10bmc, csr_map->base + offset, val); -} - +int m10bmc_sys_read(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int *val); int m10bmc_sys_update_bits(struct intel_m10bmc *m10bmc, unsigned int offset, unsigned int msk, unsigned int val); |