diff options
| author | 2026-05-21 13:25:09 +0100 | |
|---|---|---|
| committer | 2026-05-21 15:13:48 +0100 | |
| commit | 67a52d3ebb5a0ae0c0e23ffa99470d9463179c9f (patch) | |
| tree | ec6bd91d6f534fb505da6776752a7e5707c4198a /include/linux/reset/ssh:/git@git.zx2c4.com | |
| parent | Linux 7.1-rc4 (diff) | |
ASoC: cs-amp-lib: Fix wrong sizeof() in _cs_amp_set_efi_calibration_data()
When calculating data->count replace the incorrect sizeof(data) with use
of struct_offset().
The faulty sizeof(data) was incorrectly calculating the size of the
pointer instead of the size of the struct pointed to. As it happens, both
values are 8 on a 64-bit CPU. In the unlikely event of using this code on
a 32-bit CPU the number of available bytes would be calculated 4 larger
than is actually available.
Instead of changing to sizeof(*data) it has been replaced by
struct_offset() because it has better chance of detecting these sorts of
typos. Also the offset of the data[] array is actually what we want to know
here anyway.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2b62e66626f0 ("ASoC: cs-amp-lib: Add function to write calibration to UEFI")
Link: https://patch.msgid.link/20260521122511.987322-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include/linux/reset/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions
