diff options
| author |   Eric Dumazet <edumazet@google.com> | 2022-05-13 11:55:43 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-05-16 10:31:06 +0100 |
| commit | fdb5fd7f736ec7ae9fb36d2842ea6d9ebc4e7269 (patch) | |
| tree | ad8052c22224615c0aca573e509d68963ded6b48 /include/net/inet_sock.h | |
| parent | sctp: read sk->sk_bound_dev_if once in sctp_rcv() (diff) | |
| download | wireguard-linux-fdb5fd7f736ec7ae9fb36d2842ea6d9ebc4e7269.tar.xz wireguard-linux-fdb5fd7f736ec7ae9fb36d2842ea6d9ebc4e7269.zip | |
tcp: sk->sk_bound_dev_if once in inet_request_bound_dev_if()
inet_request_bound_dev_if() reads sk->sk_bound_dev_if twice
while listener socket is not locked.
Another cpu could change this field under us.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/inet_sock.h')
| -rw-r--r-- | include/net/inet_sock.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 234d70ae5f4c..c1b5dcd6597c 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -116,14 +116,15 @@ static inline u32 inet_request_mark(const struct sock *sk, struct sk_buff *skb) static inline int inet_request_bound_dev_if(const struct sock *sk, struct sk_buff *skb) { + int bound_dev_if = READ_ONCE(sk->sk_bound_dev_if); #ifdef CONFIG_NET_L3_MASTER_DEV struct net *net = sock_net(sk); - if (!sk->sk_bound_dev_if && net->ipv4.sysctl_tcp_l3mdev_accept) + if (!bound_dev_if && net->ipv4.sysctl_tcp_l3mdev_accept) return l3mdev_master_ifindex_by_index(net, skb->skb_iif); #endif - return sk->sk_bound_dev_if; + return bound_dev_if; } static inline int inet_sk_bound_l3mdev(const struct sock *sk) |