diff options
| author |   David S. Miller <davem@davemloft.net> | 2020-03-26 19:52:31 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-26 19:52:31 -0700 |
| commit | 5bb7357f45315138f623d08a615d23dd6ac26cf3 (patch) | |
| tree | 659a11744f4cbe21f69920f890780188334ef80c /include | |
| parent | Merge branch 'net-phy-marvell-usb-to-mdio-controller' (diff) | |
| parent | cls_flower: Add extack support for flags key (diff) | |
| download | wireguard-linux-5bb7357f45315138f623d08a615d23dd6ac26cf3.tar.xz wireguard-linux-5bb7357f45315138f623d08a615d23dd6ac26cf3.zip | |
Merge branch 'cls_flower-Use-extack-in-fl_set_key'
Guillaume Nault says:
====================
cls_flower: Use extack in fl_set_key()
Add missing extack messages in fl_set_key(), so that users can get more
meaningfull error messages when netlink attributes are rejected.
Patch 1 also extends extack in tcf_change_indev() (in pkt_cls.h) since
this function is used by fl_set_key().
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/pkt_cls.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 1db8b27d4515..41902e10d503 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -502,12 +502,16 @@ tcf_change_indev(struct net *net, struct nlattr *indev_tlv, struct net_device *dev; if (nla_strlcpy(indev, indev_tlv, IFNAMSIZ) >= IFNAMSIZ) { - NL_SET_ERR_MSG(extack, "Interface name too long"); + NL_SET_ERR_MSG_ATTR(extack, indev_tlv, + "Interface name too long"); return -EINVAL; } dev = __dev_get_by_name(net, indev); - if (!dev) + if (!dev) { + NL_SET_ERR_MSG_ATTR(extack, indev_tlv, + "Network device not found"); return -ENODEV; + } return dev->ifindex; } |