diff options
| author |   Jules Irenge <jbi.octave@gmail.com> | 2020-03-11 01:09:01 +0000 |
|---|---|---|
| committer |   Daniel Borkmann <daniel@iogearbox.net> | 2020-03-13 20:55:07 +0100 |
| commit | dcce11d545cc5d04c3fb529a8e2a0da987389139 (patch) | |
| tree | d235ecfa4fa2b74ecdb43d8371d8fac296ec804a /kernel | |
| parent | bpf_helpers_doc.py: Fix warning when compiling bpftool (diff) | |
| download | wireguard-linux-dcce11d545cc5d04c3fb529a8e2a0da987389139.tar.xz wireguard-linux-dcce11d545cc5d04c3fb529a8e2a0da987389139.zip | |
bpf: Add missing annotations for __bpf_prog_enter() and __bpf_prog_exit()
Sparse reports a warning at __bpf_prog_enter() and __bpf_prog_exit()
warning: context imbalance in __bpf_prog_enter() - wrong count at exit
warning: context imbalance in __bpf_prog_exit() - unexpected unlock
The root cause is the missing annotation at __bpf_prog_enter()
and __bpf_prog_exit()
Add the missing __acquires(RCU) annotation
Add the missing __releases(RCU) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200311010908.42366-2-jbi.octave@gmail.com
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/bpf/trampoline.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index f42f700c1d28..f30bca2a4d01 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -352,6 +352,7 @@ out: * call __bpf_prog_exit */ u64 notrace __bpf_prog_enter(void) + __acquires(RCU) { u64 start = 0; @@ -363,6 +364,7 @@ u64 notrace __bpf_prog_enter(void) } void notrace __bpf_prog_exit(struct bpf_prog *prog, u64 start) + __releases(RCU) { struct bpf_prog_stats *stats; |