diff options
| author |   Eric Dumazet <edumazet@google.com> | 2025-03-31 07:59:46 +0000 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2025-03-31 16:53:54 -0700 |
| commit | f278b6d5bb465c7fd66f3d103812947e55b376ed (patch) | |
| tree | 80f0f7103f809d9a485053e203a62e15e09b4c40 /net/lapb/lapb_timer.c | |
| parent | bnxt_en: bring back rtnl lock in bnxt_shutdown (diff) | |
| download | wireguard-linux-f278b6d5bb465c7fd66f3d103812947e55b376ed.tar.xz wireguard-linux-f278b6d5bb465c7fd66f3d103812947e55b376ed.zip | |
Revert "tcp: avoid atomic operations on sk->sk_rmem_alloc"
This reverts commit 0de2a5c4b824da2205658ebebb99a55c43cdf60f.
I forgot that a TCP socket could receive messages in its error queue.
sock_queue_err_skb() can be called without socket lock being held,
and changes sk->sk_rmem_alloc.
The fact that skbs in error queue are limited by sk->sk_rcvbuf
means that error messages can be dropped if socket receive
queues are full, which is an orthogonal issue.
In future kernels, we could use a separate sk->sk_error_mem_alloc
counter specifically for the error queue.
Fixes: 0de2a5c4b824 ("tcp: avoid atomic operations on sk->sk_rmem_alloc")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250331075946.31960-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions