diff options
| author |   Eric Dumazet <edumazet@google.com> | 2022-10-20 23:20:18 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-10-24 11:04:43 +0100 |
| commit | 0cafd77dcd032d1687efaba5598cf07bce85997f (patch) | |
| tree | c32efa19fb02e86944f6f71cf8e79f145432b721 /net/rds | |
| parent | Merge branch 'udp-false-sharing' (diff) | |
| download | wireguard-linux-0cafd77dcd032d1687efaba5598cf07bce85997f.tar.xz wireguard-linux-0cafd77dcd032d1687efaba5598cf07bce85997f.zip | |
net: add a refcount tracker for kernel sockets
Commit ffa84b5ffb37 ("net: add netns refcount tracker to struct sock")
added a tracker to sockets, but did not track kernel sockets.
We still have syzbot reports hinting about netns being destroyed
while some kernel TCP sockets had not been dismantled.
This patch tracks kernel sockets, and adds a ref_tracker_dir_print()
call to net_free() right before the netns is freed.
Normally, each layer is responsible for properly releasing its
kernel sockets before last call to net_free().
This debugging facility is enabled with CONFIG_NET_NS_REFCNT_TRACKER=y
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Tested-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
| -rw-r--r-- | net/rds/tcp.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 4444fd82b66d..c5b86066ff66 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -503,6 +503,9 @@ bool rds_tcp_tune(struct socket *sock) release_sock(sk); return false; } + /* Update ns_tracker to current stack trace and refcounted tracker */ + __netns_tracker_free(net, &sk->ns_tracker, false); + sk->sk_net_refcnt = 1; netns_tracker_alloc(net, &sk->ns_tracker, GFP_KERNEL); sock_inuse_add(net, 1); |