diff options
| author |   Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-05-25 22:17:02 +0800 |
|---|---|---|
| committer |   J. Bruce Fields <bfields@redhat.com> | 2020-05-28 18:15:00 -0400 |
| commit | 037e910b52b04fbd41990f643dff97c7e43b0e47 (patch) | |
| tree | b96d1760d43c77b4364360c4899d7427e4656555 /net/sunrpc | |
| parent | nfsd: Fix svc_xprt refcnt leak when setup callback client failed (diff) | |
| download | wireguard-linux-037e910b52b04fbd41990f643dff97c7e43b0e47.tar.xz wireguard-linux-037e910b52b04fbd41990f643dff97c7e43b0e47.zip | |
SUNRPC: Remove unreachable error condition in rpcb_getport_async()
rpcb_getport_async() invokes rpcb_call_async(), which return the value
of rpc_run_task() to "child". Since rpc_run_task() is impossible to
return an ERR pointer, there is no need to add the IS_ERR() condition on
"child" here. So we need to remove it.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/rpcb_clnt.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c index 4a020b688860..c27123e6ba80 100644 --- a/net/sunrpc/rpcb_clnt.c +++ b/net/sunrpc/rpcb_clnt.c @@ -795,12 +795,6 @@ void rpcb_getport_async(struct rpc_task *task) child = rpcb_call_async(rpcb_clnt, map, proc); rpc_release_client(rpcb_clnt); - if (IS_ERR(child)) { - /* rpcb_map_release() has freed the arguments */ - dprintk("RPC: %5u %s: rpc_run_task failed\n", - task->tk_pid, __func__); - return; - } xprt->stat.bind_count++; rpc_put_task(child); |