diff options
| author |   Daniel Borkmann <daniel@iogearbox.net> | 2018-08-24 22:08:51 +0200 |
|---|---|---|
| committer |   Alexei Starovoitov <ast@kernel.org> | 2018-08-27 20:22:05 -0700 |
| commit | 15c480efab01197c965ce0562a43ffedd852b8f9 (patch) | |
| tree | 2f1a088152b28f8eb27233cf2aa2bc6a209f4974 /net/tipc/socket.h | |
| parent | bpf, sockmap: fix potential use after free in bpf_tcp_close (diff) | |
| download | wireguard-linux-15c480efab01197c965ce0562a43ffedd852b8f9.tar.xz wireguard-linux-15c480efab01197c965ce0562a43ffedd852b8f9.zip | |
bpf, sockmap: fix psock refcount leak in bpf_tcp_recvmsg
In bpf_tcp_recvmsg() we first took a reference on the psock, however
once we find that there are skbs in the normal socket's receive queue
we return with processing them through tcp_recvmsg(). Problem is that
we leak the taken reference on the psock in that path. Given we don't
really do anything with the psock at this point, move the skb_queue_empty()
test before we fetch the psock to fix this case.
Fixes: 8934ce2fd081 ("bpf: sockmap redirect ingress support")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'net/tipc/socket.h')
0 files changed, 0 insertions, 0 deletions