diff options
| author |   Nikolay Kuratov <kniv@yandex-team.ru> | 2023-12-11 19:23:17 +0300 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2023-12-13 17:59:08 -0800 |
| commit | 60316d7f10b17a7ebb1ead0642fee8710e1560e0 (patch) | |
| tree | d3e0dec3a5925949c663bd6340750248626b9886 /net/vmw_vsock | |
| parent | Revert "tcp: disable tcp_autocorking for socket when TCP_NODELAY flag is set" (diff) | |
| download | wireguard-linux-60316d7f10b17a7ebb1ead0642fee8710e1560e0.tar.xz wireguard-linux-60316d7f10b17a7ebb1ead0642fee8710e1560e0.zip | |
vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()
We need to do signed arithmetic if we expect condition
`if (bytes < 0)` to be possible
Found by Linux Verification Center (linuxtesting.org) with SVACE
Fixes: 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")
Signed-off-by: Nikolay Kuratov <kniv@yandex-team.ru>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20231211162317.4116625-1-kniv@yandex-team.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/vmw_vsock')
| -rw-r--r-- | net/vmw_vsock/virtio_transport_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index c8e162c9d1df..6df246b53260 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -843,7 +843,7 @@ static s64 virtio_transport_has_space(struct vsock_sock *vsk) struct virtio_vsock_sock *vvs = vsk->trans; s64 bytes; - bytes = vvs->peer_buf_alloc - (vvs->tx_cnt - vvs->peer_fwd_cnt); + bytes = (s64)vvs->peer_buf_alloc - (vvs->tx_cnt - vvs->peer_fwd_cnt); if (bytes < 0) bytes = 0; |