aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/net
diff options
context:
space:
mode:
authorSiddh Raman Pant <siddh.raman.pant@oracle.com>2025-02-15 09:40:51 +0000
committerJakub Kicinski <kuba@kernel.org>2025-02-18 18:03:12 -0800
commit438989137acd6c620e9990c24dead5ffdd8e77c1 (patch)
treea19fa3b2b42b017a52d241616af35cf07ca6db9e /net
parentMerge branch 'net-cadence-macb-modernize-statistics-reporting' (diff)
downloadwireguard-linux-438989137acd6c620e9990c24dead5ffdd8e77c1.tar.xz
wireguard-linux-438989137acd6c620e9990c24dead5ffdd8e77c1.zip
netlink: Unset cb_running when terminating dump on release
When we terminated the dump, the callback isn't running, so cb_running should be set to false to be logically consistent. cb_running signifies whether a dump is ongoing. It is set to true in cb->start(), and is checked in netlink_dump() to be true initially. After the dump, it is set to false in the same function. This is just a cleanup, no path should access this field on a closed socket. Signed-off-by: Siddh Raman Pant <siddh.raman.pant@oracle.com> Link: https://patch.msgid.link/aff028e3eb2b768b9895fa6349fa1981ae22f098.camel@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/netlink/af_netlink.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 85311226183a..f8f13058a46e 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -771,6 +771,7 @@ static int netlink_release(struct socket *sock)
nlk->cb.done(&nlk->cb);
module_put(nlk->cb.module);
kfree_skb(nlk->cb.skb);
+ WRITE_ONCE(nlk->cb_running, false);
}
module_put(nlk->module);