diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2025-02-14 14:43:40 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-02-17 16:47:01 -0800 |
| commit | 637026e591fae3b91986c01e3beab9bb664bda2d (patch) | |
| tree | 7a4d2fb0a2da2da1700d7d100d9bb045dd15a04e /net | |
| parent | Merge branch 'netdev-genl-add-an-xsk-attribute-to-queues' (diff) | |
| download | wireguard-linux-637026e591fae3b91986c01e3beab9bb664bda2d.tar.xz wireguard-linux-637026e591fae3b91986c01e3beab9bb664bda2d.zip | |
net: move stale comment about ntuple validation
Gal points out that the comment now belongs further down, since
the original if condition was split into two in
commit de7f7582dff2 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")
Link: https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com
Reviewed-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250214224340.2268691-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ethtool/ioctl.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 98b7dcea207a..271c7cef9ef3 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -992,8 +992,10 @@ static noinline_for_stack int ethtool_set_rxnfc(struct net_device *dev, if (rc) return rc; - /* Nonzero ring with RSS only makes sense if NIC adds them together */ if (cmd == ETHTOOL_SRXCLSRLINS && info.fs.flow_type & FLOW_RSS) { + /* Nonzero ring with RSS only makes sense + * if NIC adds them together + */ if (!ops->cap_rss_rxnfc_adds && ethtool_get_flow_spec_ring(info.fs.ring_cookie)) return -EINVAL; |