diff options
| author |   Erni Sri Satya Vennela <ernis@linux.microsoft.com> | 2026-04-20 05:47:38 -0700 |
|---|---|---|
| committer |   Paolo Abeni <pabeni@redhat.com> | 2026-04-23 12:49:13 +0200 |
| commit | a7fdaf069bd031fcc234581fa6a580be11bf2175 (patch) | |
| tree | c193521a1e1d28975e536f9e9b381ad1bc0fa166 /samples/kobject/ssh:/git@git.zx2c4.com | |
| parent | net: mana: Guard mana_remove against double invocation (diff) | |
net: mana: Don't overwrite port probe error with add_adev result
In mana_probe(), if mana_probe_port() fails for any port, the error
is stored in 'err' and the loop breaks. However, the subsequent
unconditional 'err = add_adev(gd, "eth")' overwrites this error.
If add_adev() succeeds, mana_probe() returns success despite ports
being left in a partially initialized state (ac->ports[i] == NULL).
Only call add_adev() when there is no prior error, so the probe
correctly fails and triggers mana_remove() cleanup.
Fixes: a69839d4327d ("net: mana: Add support for auxiliary device")
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Link: https://patch.msgid.link/20260420124741.1056179-5-ernis@linux.microsoft.com
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'samples/kobject/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions