diff options
| author |   Johan Hovold <johan@kernel.org> | 2019-10-09 19:09:42 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-10 12:41:18 +0200 |
| commit | bed5ef230943863b9abf5eae226a20fad9a8ff71 (patch) | |
| tree | 5b6beb207aed9dc04a15c193f21da5e61d8c6c73 /scripts/gdb/linux/utils.py | |
| parent | usb:cdns3: Fix for CV CH9 running with g_zero driver. (diff) | |
| download | wireguard-linux-bed5ef230943863b9abf5eae226a20fad9a8ff71.tar.xz wireguard-linux-bed5ef230943863b9abf5eae226a20fad9a8ff71.zip | |
USB: usb-skeleton: fix NULL-deref on disconnect
The driver was using its struct usb_interface pointer as an inverted
disconnected flag and was setting it to NULL before making sure all
completion handlers had run. This could lead to NULL-pointer
dereferences in the dev_err() statements in the completion handlers
which relies on said pointer.
Fix this by using a dedicated disconnected flag.
Note that this is also addresses a NULL-pointer dereference at release()
and a struct usb_interface reference leak introduced by a recent runtime
PM fix, which depends on and should have been submitted together with
this patch.
Fixes: 4212cd74ca6f ("USB: usb-skeleton.c: remove err() usage")
Fixes: 5c290a5e42c3 ("USB: usb-skeleton: fix runtime PM after driver unbind")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009170944.30057-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'scripts/gdb/linux/utils.py')
0 files changed, 0 insertions, 0 deletions