diff options
| author |   Dan Carpenter <dan.carpenter@linaro.org> | 2024-12-11 12:32:34 +0300 |
|---|---|---|
| committer |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2025-01-13 00:20:55 +0100 |
| commit | 09c4a610153286cef54d4f0c85398f4e32fc227e (patch) | |
| tree | 8913bb973922a35240c5066c9e52c5da8b004445 /scripts/generate_rust_analyzer.py | |
| parent | rtc: use boolean values with device_init_wakeup() (diff) | |
| download | wireguard-linux-09c4a610153286cef54d4f0c85398f4e32fc227e.tar.xz wireguard-linux-09c4a610153286cef54d4f0c85398f4e32fc227e.zip | |
rtc: tps6594: Fix integer overflow on 32bit systems
The problem is this multiply in tps6594_rtc_set_offset()
tmp = offset * TICKS_PER_HOUR;
The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range. On 32bit systems a long can hold numbers up to
approximately two billion. The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million. When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.
Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.
Fixes: 9f67c1e63976 ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions