diff options
| author |   Takashi Iwai <tiwai@suse.de> | 2012-10-25 13:55:51 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2012-10-25 13:55:51 +0200 |
| commit | 7dd7a2fd7eb147a610506f6c6f871c03908fc58a (patch) | |
| tree | 1f9dfac1775587f069ff6322955cfc33d222f283 /sound/pci/au88x0 | |
| parent | ALSA: sound/usb: remove CONFIG_EXPERIMENTAL (diff) | |
| download | wireguard-linux-7dd7a2fd7eb147a610506f6c6f871c03908fc58a.tar.xz wireguard-linux-7dd7a2fd7eb147a610506f6c6f871c03908fc58a.zip | |
ALSA: au88x0: Give comment for vortex_wtdma_bufshift() issue
The check of the return value from vortex_wtdma_bufshft() in
vortex_interrupt() is useless as it executes no code. Actually the
return value is intentionally ignored because the delta calculation
for wavetable doesn't work always correctly. For avoiding the
confusion, a comment is added and the superfluous if () is removed.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/au88x0')
| -rw-r--r-- | sound/pci/au88x0/au88x0_core.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c index 525f881f0409..2698abf5d05d 100644 --- a/sound/pci/au88x0/au88x0_core.c +++ b/sound/pci/au88x0/au88x0_core.c @@ -2461,7 +2461,12 @@ static irqreturn_t vortex_interrupt(int irq, void *dev_id) #ifndef CHIP_AU8810 for (i = 0; i < NR_WT; i++) { if (vortex->dma_wt[i].fifo_status == FIFO_START) { - if (vortex_wtdma_bufshift(vortex, i)) ; + /* FIXME: we ignore the return value from + * vortex_wtdma_bufshift() below as the delta + * calculation seems not working for wavetable + * by some reason + */ + vortex_wtdma_bufshift(vortex, i); spin_unlock(&vortex->lock); snd_pcm_period_elapsed(vortex->dma_wt[i]. substream); |