diff options
| author |   Chuhong Yuan <hslester96@gmail.com> | 2020-12-03 22:42:27 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2020-12-04 17:46:06 +0000 |
| commit | 1c1fb2653a0c2e3f310c07eacd8fc3a10e08c97a (patch) | |
| tree | da461431c6e4e2d0c8713c8da3965f9a39af2a70 /sound/soc/jz4740 | |
| parent | ASoC: Intel: Boards: tgl_max98373: update TDM slot_width (diff) | |
| download | wireguard-linux-1c1fb2653a0c2e3f310c07eacd8fc3a10e08c97a.tar.xz wireguard-linux-1c1fb2653a0c2e3f310c07eacd8fc3a10e08c97a.zip | |
ASoC: jz4740-i2s: add missed checks for clk_get()
jz4740_i2s_set_sysclk() does not check the return values of clk_get(),
while the file dereferences the pointers in clk_put().
Add the missed checks to fix it.
Fixes: 11bd3dd1b7c2 ("ASoC: Add JZ4740 ASoC support")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20201203144227.418194-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/jz4740')
| -rw-r--r-- | sound/soc/jz4740/jz4740-i2s.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c index c7bd20104b20..0793e284d0e7 100644 --- a/sound/soc/jz4740/jz4740-i2s.c +++ b/sound/soc/jz4740/jz4740-i2s.c @@ -312,10 +312,14 @@ static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id, switch (clk_id) { case JZ4740_I2S_CLKSRC_EXT: parent = clk_get(NULL, "ext"); + if (IS_ERR(parent)) + return PTR_ERR(parent); clk_set_parent(i2s->clk_i2s, parent); break; case JZ4740_I2S_CLKSRC_PLL: parent = clk_get(NULL, "pll half"); + if (IS_ERR(parent)) + return PTR_ERR(parent); clk_set_parent(i2s->clk_i2s, parent); ret = clk_set_rate(i2s->clk_i2s, freq); break; |