diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-06-03 17:06:39 +0400 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-06-06 12:38:27 +0100 |
| commit | 3e2649c5e8643bea0867bb1dd970fedadb0eb7f3 (patch) | |
| tree | 644485347f3799bee6be36f141630f021afe781b /sound/soc/samsung | |
| parent | ASoC: cros_ec_codec: Fix refcount leak in cros_ec_codec_platform_probe (diff) | |
| download | wireguard-linux-3e2649c5e8643bea0867bb1dd970fedadb0eb7f3.tar.xz wireguard-linux-3e2649c5e8643bea0867bb1dd970fedadb0eb7f3.zip | |
ASoC: samsung: Fix error handling in aries_audio_probe
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function is missing of_node_put(cpu) in the error path.
Fix this by goto out label. of_node_put() will check NULL pointer.
Fixes: 7a3a7671fa6c ("ASoC: samsung: Add driver for Aries boards")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220603130640.37624-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/samsung')
| -rw-r--r-- | sound/soc/samsung/aries_wm8994.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c index bb0cf4244e00..edee02d7f100 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -628,8 +628,10 @@ static int aries_audio_probe(struct platform_device *pdev) return -EINVAL; codec = of_get_child_by_name(dev->of_node, "codec"); - if (!codec) - return -EINVAL; + if (!codec) { + ret = -EINVAL; + goto out; + } for_each_card_prelinks(card, i, dai_link) { dai_link->codecs->of_node = of_parse_phandle(codec, |