diff options
| author |   Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2022-03-31 14:47:57 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-04-05 10:23:20 +0100 |
| commit | a403993ce98fb401f696da7c4f374739a7609cff (patch) | |
| tree | db21b6cfafcd9d154988cc8e8080cf27c3a6574e /sound/soc/sof/ipc3-topology.c | |
| parent | ASoC: cs*: use simple i2c probe function (diff) | |
| download | wireguard-linux-a403993ce98fb401f696da7c4f374739a7609cff.tar.xz wireguard-linux-a403993ce98fb401f696da7c4f374739a7609cff.zip | |
ASoC: SOF: ipc3-topology: Set scontrol->priv to NULL after freeing it
Since the scontrol->priv is freed up during load operation it should be set
to NULL to be safe against double freeing attempt.
Fixes: b5cee8feb1d48 ("ASoC: SOF: topology: Make control parsing IPC agnostic")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220331114757.32551-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/ipc3-topology.c')
| -rw-r--r-- | sound/soc/sof/ipc3-topology.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index 2f8450a8c0a1..2e1c76ed087d 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -1592,6 +1592,7 @@ static int sof_ipc3_control_load_bytes(struct snd_sof_dev *sdev, struct snd_sof_ if (scontrol->priv_size > 0) { memcpy(cdata->data, scontrol->priv, scontrol->priv_size); kfree(scontrol->priv); + scontrol->priv = NULL; if (cdata->data->magic != SOF_ABI_MAGIC) { dev_err(sdev->dev, "Wrong ABI magic 0x%08x.\n", cdata->data->magic); |