diff options
| author |   Ranjani Sridharan <ranjani.sridharan@linux.intel.com> | 2022-04-26 10:17:42 -0700 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-04-29 13:06:04 +0100 |
| commit | 463a809ba8efa127484d16ff588e3bcdb63fe41e (patch) | |
| tree | f69518265819ca82e96ccc45993b7a014ab62d1d /sound/soc/sof/sof-audio.c | |
| parent | ASoC: SOF: topology: Skip parsing DAI link tokens if not needed (diff) | |
| download | wireguard-linux-463a809ba8efa127484d16ff588e3bcdb63fe41e.tar.xz wireguard-linux-463a809ba8efa127484d16ff588e3bcdb63fe41e.zip | |
ASoC: SOF: clarify use of widget complete flag
Currently, the complete flag is used only for the snd_soc_dapm_scheduler
type widgets to indicate that the pipeline has been set up. All other
widgets do not need it. Add a comment to clarify its usage and set the
complete flag to false only for the scheduler widget in
sof_widget_free().
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220426171743.171061-11-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/sof-audio.c')
| -rw-r--r-- | sound/soc/sof/sof-audio.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/sof/sof-audio.c b/sound/soc/sof/sof-audio.c index b2da078a1641..791d2454c1d5 100644 --- a/sound/soc/sof/sof-audio.c +++ b/sound/soc/sof/sof-audio.c @@ -58,8 +58,6 @@ int sof_widget_free(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget) err = ret; } - swidget->complete = 0; - /* * free the scheduler widget (same as pipe_widget) associated with the current swidget. * skip for static pipelines @@ -68,6 +66,7 @@ int sof_widget_free(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget) ret = sof_widget_free(sdev, swidget->pipe_widget); if (ret < 0 && !err) err = ret; + swidget->pipe_widget->complete = 0; } if (!err) |