diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-15 16:07:38 +0100 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2023-03-20 13:09:31 +0000 |
| commit | 048d658978107f1a6b517297acb2eb08dd70b4c7 (patch) | |
| tree | f71f899d6546da6ec391746bacb4b44059db06f1 /sound/soc/uniphier | |
| parent | ASoC: ti: omap-mcbsp: Convert to platform remove callback returning void (diff) | |
| download | wireguard-linux-048d658978107f1a6b517297acb2eb08dd70b4c7.tar.xz wireguard-linux-048d658978107f1a6b517297acb2eb08dd70b4c7.zip | |
ASoC: uniphier: evea: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-167-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/uniphier')
| -rw-r--r-- | sound/soc/uniphier/evea.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/sound/soc/uniphier/evea.c b/sound/soc/uniphier/evea.c index 42403ae8e31b..d90b3e4b0104 100644 --- a/sound/soc/uniphier/evea.c +++ b/sound/soc/uniphier/evea.c @@ -536,7 +536,7 @@ err_out_clock: return ret; } -static int evea_remove(struct platform_device *pdev) +static void evea_remove(struct platform_device *pdev) { struct evea_priv *evea = platform_get_drvdata(pdev); @@ -546,8 +546,6 @@ static int evea_remove(struct platform_device *pdev) clk_disable_unprepare(evea->clk_exiv); clk_disable_unprepare(evea->clk); - - return 0; } static const struct of_device_id evea_of_match[] __maybe_unused = { @@ -562,7 +560,7 @@ static struct platform_driver evea_codec_driver = { .of_match_table = of_match_ptr(evea_of_match), }, .probe = evea_probe, - .remove = evea_remove, + .remove_new = evea_remove, }; module_platform_driver(evea_codec_driver); |