path: root/sound
diff options
authorAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>2020-04-15 12:28:49 -0400
committerMark Brown <broonie@kernel.org>2020-04-16 13:01:33 +0100
commit326b509238171d37402dbe308e154cc234ed1960 (patch)
treedc81b4eb669fcf3a6afb954e49f7ffb38cc6ab38 /sound
parentASoC: soc-dai: revert all changes to DAI startup/shutdown sequence (diff)
ASoC: codecs: hdac_hdmi: Fix incorrect use of list_for_each_entry
If we don't find any pcm, pcm will point at address at an offset from the the list head and not a meaningful structure. Fix this by returning correct pcm if found and NULL if not. Found with coccinelle. Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> Link: https://lore.kernel.org/r/20200415162849.308-1-amadeuszx.slawinski@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
index fba9b749839d..f26b77faed59 100644
--- a/sound/soc/codecs/hdac_hdmi.c
+++ b/sound/soc/codecs/hdac_hdmi.c
@@ -142,14 +142,14 @@ static struct hdac_hdmi_pcm *
hdac_hdmi_get_pcm_from_cvt(struct hdac_hdmi_priv *hdmi,
struct hdac_hdmi_cvt *cvt)
- struct hdac_hdmi_pcm *pcm = NULL;
+ struct hdac_hdmi_pcm *pcm;
list_for_each_entry(pcm, &hdmi->pcm_list, head) {
if (pcm->cvt == cvt)
- break;
+ return pcm;
- return pcm;
+ return NULL;
static void hdac_hdmi_jack_report(struct hdac_hdmi_pcm *pcm,