diff options
| author |   Josh Poimboeuf <jpoimboe@kernel.org> | 2025-05-07 16:56:55 -0700 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2025-05-14 13:09:02 +0200 |
| commit | 4ed9d82bf5b21d65e2f18249eec89a6a84df8f23 (patch) | |
| tree | fe4280c54b29644b7860378b5857fb65880c8dcf /tools/objtool/include | |
| parent | objtool: Fix up st_info in COMDAT group section (diff) | |
| download | wireguard-linux-4ed9d82bf5b21d65e2f18249eec89a6a84df8f23.tar.xz wireguard-linux-4ed9d82bf5b21d65e2f18249eec89a6a84df8f23.zip | |
objtool: Speed up SHT_GROUP reindexing
After elf_update_group_sh_info() was introduced, a prototype version of
"objtool klp diff" went from taking ~1s to several minutes, due to
looping almost endlessly in elf_update_group_sh_info() while creating
thousands of local symbols in a file with thousands of sections.
Dramatically improve the performance by marking all symbols' correlated
SHT_GROUP sections while reading the object. That way there's no need
to search for it every time a symbol gets reindexed.
Fixes: 2cb291596e2c ("objtool: Fix up st_info in COMDAT group section")
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Rong Xu <xur@google.com>
Link: https://lkml.kernel.org/r/2a33e583c87e3283706f346f9d59aac20653b7fd.1746662991.git.jpoimboe@kernel.org
Diffstat (limited to 'tools/objtool/include')
| -rw-r--r-- | tools/objtool/include/objtool/elf.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/objtool/include/objtool/elf.h b/tools/objtool/include/objtool/elf.h index c7c4e87ebe88..0a2fa3ac0079 100644 --- a/tools/objtool/include/objtool/elf.h +++ b/tools/objtool/include/objtool/elf.h @@ -72,6 +72,7 @@ struct symbol { u8 ignore : 1; struct list_head pv_target; struct reloc *relocs; + struct section *group_sec; }; struct reloc { |