diff options
author | 2025-08-15 10:30:50 +0800 | |
---|---|---|
committer | 2025-08-28 13:40:03 +0200 | |
commit | 0e20450829ca3c1dbc2db536391537c57a40fe0b (patch) | |
tree | e0569da537181017ef868d6c84232fb621766aac /tools/perf/scripts/python/Perf-Trace-Util/lib | |
parent | wifi: mac80211: do not permit 40 MHz EHT operation on 5/6 GHz (diff) | |
download | wireguard-linux-0e20450829ca3c1dbc2db536391537c57a40fe0b.tar.xz wireguard-linux-0e20450829ca3c1dbc2db536391537c57a40fe0b.zip |
wifi: mwifiex: Initialize the chan_stats array to zero
The adapter->chan_stats[] array is initialized in
mwifiex_init_channel_scan_gap() with vmalloc(), which doesn't zero out
memory. The array is filled in mwifiex_update_chan_statistics()
and then the user can query the data in mwifiex_cfg80211_dump_survey().
There are two potential issues here. What if the user calls
mwifiex_cfg80211_dump_survey() before the data has been filled in.
Also the mwifiex_update_chan_statistics() function doesn't necessarily
initialize the whole array. Since the array was not initialized at
the start that could result in an information leak.
Also this array is pretty small. It's a maximum of 900 bytes so it's
more appropriate to use kcalloc() instead vmalloc().
Cc: stable@vger.kernel.org
Fixes: bf35443314ac ("mwifiex: channel statistics support for mwifiex")
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20250815023055.477719-1-rongqianfeng@vivo.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'tools/perf/scripts/python/Perf-Trace-Util/lib')
0 files changed, 0 insertions, 0 deletions