diff options
author | 2025-04-17 11:28:23 +0100 | |
---|---|---|
committer | 2025-04-21 18:36:54 -0700 | |
commit | 199561a48f026bf674424fd9019c0690a3570377 (patch) | |
tree | 1100597aad769c287ddb3643a2b02850fe327954 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | net/mlx5: Fix spelling mistakes in mlx5_core_dbg message and comments (diff) | |
download | wireguard-linux-199561a48f026bf674424fd9019c0690a3570377.tar.xz wireguard-linux-199561a48f026bf674424fd9019c0690a3570377.zip |
s390: ism: Pass string literal as format argument of dev_set_name()
GCC 14.2.0 reports that passing a non-string literal as the
format argument of dev_set_name() is potentially insecure.
drivers/s390/net/ism_drv.c: In function 'ism_probe':
drivers/s390/net/ism_drv.c:615:2: warning: format not a string literal and no format arguments [-Wformat-security]
615 | dev_set_name(&ism->dev, dev_name(&pdev->dev));
| ^~~~~~~~~~~~
It seems to me that as pdev is a PCIE device then the dev_name
call above should always return the device's BDF, e.g. 00:12.0.
That this should not contain format escape sequences. And thus
the current usage is safe.
But, it seems better to be safe than sorry. And, as a bonus, compiler
output becomes less verbose by addressing this issue.
Compile tested only.
No functional change intended.
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250417-ism-str-fmt-v1-1-9818b029874d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions