diff options
| author |   Florian Westphal <fw@strlen.de> | 2018-05-06 00:45:43 +0200 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2018-05-08 14:15:31 +0200 |
| commit | 4e09fc873d92398001e267f7b60c36c963f825b3 (patch) | |
| tree | 020b1146c61c4a25e286cdc53b51411b6280ae5b /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | netfilter: core: add missing __rcu annotation (diff) | |
| download | wireguard-linux-4e09fc873d92398001e267f7b60c36c963f825b3.tar.xz wireguard-linux-4e09fc873d92398001e267f7b60c36c963f825b3.zip | |
netfilter: prefer nla_strlcpy for dealing with NLA_STRING attributes
fixes these warnings:
'nfnl_cthelper_create' at net/netfilter/nfnetlink_cthelper.c:237:2,
'nfnl_cthelper_new' at net/netfilter/nfnetlink_cthelper.c:450:9:
./include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
return __builtin_strncpy(p, q, size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Moreover, strncpy assumes null-terminated source buffers, but thats
not the case here.
Unlike strlcpy, nla_strlcpy *does* pad the destination buffer
while also considering nla attribute size.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions