diff options
author | 2023-08-10 07:48:10 -0700 | |
---|---|---|
committer | 2023-08-10 07:48:10 -0700 | |
commit | d728f4e3b21e74910e370b09bab54629eb66badb (patch) | |
tree | 7f939a932324d6828908c3d2fc26cd2a1d9a52a7 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | xfs: always rescan allegedly healthy per-ag metadata after repair (diff) | |
download | wireguard-linux-d728f4e3b21e74910e370b09bab54629eb66badb.tar.xz wireguard-linux-d728f4e3b21e74910e370b09bab54629eb66badb.zip |
xfs: allow the user to cancel repairs before we start writing
All online repair functions have the same structure: walk filesystem
metadata structures gathering enough data to rebuild the structure,
stage a new copy, and then commit the new copy.
The gathering steps do not write anything to disk, so they are peppered
with xchk_should_terminate calls to avoid softlockup warnings and to
provide an opportunity to abort the repair (by killing xfs_scrub).
However, it's not clear in the code base when is the last chance to
abort cleanly without having to undo a bunch of structure.
Therefore, add one more call to xchk_should_terminate (along with a
comment) providing the sysadmin with the ability to abort before it's
too late and to make it clear in the source code when it's no longer
convenient or safe to abort a repair. As there are only four repair
functions right now, this patch exists more to establish a precedent for
subsequent additions than to deliver practical functionality.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions