diff options
author | 2023-10-19 22:47:58 +0000 | |
---|---|---|
committer | 2023-10-20 19:48:11 +0200 | |
commit | eda1a74655ea282fcac56af5ca18ff1394542e29 (patch) | |
tree | 42c74bc00d4e36036a76e67a01a736a19a200dba /tools/perf/scripts/python/export-to-postgresql.py | |
parent | PNP: Clean up coding style in pnp.h (diff) | |
download | wireguard-linux-eda1a74655ea282fcac56af5ca18ff1394542e29.tar.xz wireguard-linux-eda1a74655ea282fcac56af5ca18ff1394542e29.zip |
PNP: ACPI: replace deprecated strncpy() with strscpy()
strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
We know dev->name should be NUL-terminated based on the presence of a
manual NUL-byte assignment.
NUL-padding is not required as dev is already zero-allocated which
renders any further NUL-byte assignments redundant:
dev = pnp_alloc_dev(&pnpacpi_protocol, num, pnpid); --->
dev = kzalloc(sizeof(struct pnp_dev), GFP_KERNEL);
Considering the above, a suitable replacement is `strscpy` [2] due to
the fact that it guarantees NUL-termination on the destination buffer
without unnecessarily NUL-padding. This simplifies the code and makes
the intent/behavior more obvious.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions