diff options
| author |   Rand Deeb <rand.sec96@gmail.com> | 2025-03-06 13:12:00 +0300 |
|---|---|---|
| committer |   Tony Nguyen <anthony.l.nguyen@intel.com> | 2025-04-11 11:58:58 -0700 |
| commit | cdcb3804eeda24d588348bbab6766cf14fddbeaa (patch) | |
| tree | 0e95d1bb86aa199127c070e7198fd3d53864deab /tools/perf/scripts/python/exported-sql-viewer.py | |
| parent | i40e: fix MMIO write access to an invalid page in i40e_clear_hw (diff) | |
| download | wireguard-linux-cdcb3804eeda24d588348bbab6766cf14fddbeaa.tar.xz wireguard-linux-cdcb3804eeda24d588348bbab6766cf14fddbeaa.zip | |
ixgbe: Fix unreachable retry logic in combined and byte I2C write functions
The current implementation of `ixgbe_write_i2c_combined_generic_int` and
`ixgbe_write_i2c_byte_generic_int` sets `max_retry` to `1`, which makes
the condition `retry < max_retry` always evaluate to `false`. This renders
the retry mechanism ineffective, as the debug message and retry logic are
never executed.
This patch increases `max_retry` to `3` in both functions, aligning them
with the retry logic in `ixgbe_read_i2c_combined_generic_int`. This
ensures that the retry mechanism functions as intended, improving
robustness in case of I2C write failures.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Rand Deeb <rand.sec96@gmail.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions