diff options
| author |   Shitalkumar Gandhi <shital.gandhi45@gmail.com> | 2026-05-11 09:57:32 +0530 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2026-05-20 11:19:55 +0200 |
| commit | dd7b6a8671939708cc4b7a46786d8c11297e8f69 (patch) | |
| tree | 1508fe526b483f11c677ec72314a53332cee6c99 /tools/testing/selftests/dm-verity/git:/ssh:/git@git.zx2c4.com | |
| parent | wifi: mac80211: capture fast-RX rate before mesh reuses skb->cb (diff) | |
wifi: wilc1000: fix dma_buffer leak on bus acquire failure
wilc_wlan_firmware_download() allocates dma_buffer with kmalloc() at
the top of the function and uses a 'fail:' label to free it via
kfree(dma_buffer) on error.
All later error paths correctly use 'goto fail' to route through this
cleanup. However, the early failure path after the first acquire_bus()
call uses a bare 'return ret;', which leaks dma_buffer whenever the bus
acquire fails.
Replace the early return with goto fail so the existing cleanup path
runs.
Found via a custom Coccinelle semantic patch hunting for kmalloc'd
locals leaked on early-return error paths in driver firmware-download
code.
Fixes: 1241c5650ff7 ("wifi: wilc1000: Fill in missing error handling")
Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260511042732.998311-1-shitalkumar.gandhi@cambiumnetworks.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'tools/testing/selftests/dm-verity/git:/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions