diff options
| author |   Mathieu Desnoyers <mathieu.desnoyers@efficios.com> | 2022-01-24 12:12:51 -0500 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2022-02-02 13:11:37 +0100 |
| commit | b53823fb2ef854222853be164f3b1e815f315144 (patch) | |
| tree | e126d258e4bfbeb92ffba13eebfe87b1116f260b /tools/testing/selftests/rseq/rseq.h | |
| parent | selftests/rseq: Remove arm/mips asm goto compiler work-around (diff) | |
| download | wireguard-linux-b53823fb2ef854222853be164f3b1e815f315144.tar.xz wireguard-linux-b53823fb2ef854222853be164f3b1e815f315144.zip | |
selftests/rseq: Fix: work-around asm goto compiler bugs
gcc and clang each have their own compiler bugs with respect to asm
goto. Implement a work-around for compiler versions known to have those
bugs.
gcc prior to 4.8.2 miscompiles asm goto.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670
gcc prior to 8.1.0 miscompiles asm goto at O1.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103908
clang prior to version 13.0.1 miscompiles asm goto at O2.
https://github.com/llvm/llvm-project/issues/52735
Work around these issues by adding a volatile inline asm with
memory clobber in the fallthrough after the asm goto and at each
label target. Emit this for all compilers in case other similar
issues are found in the future.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220124171253.22072-14-mathieu.desnoyers@efficios.com
Diffstat (limited to 'tools/testing/selftests/rseq/rseq.h')
| -rw-r--r-- | tools/testing/selftests/rseq/rseq.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/testing/selftests/rseq/rseq.h b/tools/testing/selftests/rseq/rseq.h index 17531ccd3090..6bd0ac466b4a 100644 --- a/tools/testing/selftests/rseq/rseq.h +++ b/tools/testing/selftests/rseq/rseq.h @@ -17,6 +17,7 @@ #include <stdio.h> #include <stdlib.h> #include "rseq-abi.h" +#include "compiler.h" /* * Empty code injection macros, override when testing. |