diff options
| author |   Jason A. Donenfeld <Jason@zx2c4.com> | 2018-07-31 07:03:07 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2018-07-31 07:19:52 +0200 |
| commit | b713ab0e605b4f9291f4fde38103bf689c2cdb76 (patch) | |
| tree | e18f74fc2795b8c8b80141e8bf411a8a22959dc2 /src/queueing.h | |
| parent | ratelimiter: prevent init/uninit race (diff) | |
| download | wireguard-monolithic-historical-b713ab0e605b4f9291f4fde38103bf689c2cdb76.tar.xz wireguard-monolithic-historical-b713ab0e605b4f9291f4fde38103bf689c2cdb76.zip | |
peer: simplify rcu reference counts
Use RCU reference counts only when we must, and otherwise use a more
reasonably named function.
Reported-by: Jann Horn <jann@thejh.net>
Diffstat (limited to 'src/queueing.h')
| -rw-r--r-- | src/queueing.h | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/queueing.h b/src/queueing.h index c17b0d8..3fb7b5c 100644 --- a/src/queueing.h +++ b/src/queueing.h @@ -132,20 +132,14 @@ static inline int queue_enqueue_per_device_and_peer(struct crypt_queue *device_q static inline void queue_enqueue_per_peer(struct crypt_queue *queue, struct sk_buff *skb, enum packet_state state) { - struct wireguard_peer *peer = peer_rcu_get(PACKET_PEER(skb)); - atomic_set(&PACKET_CB(skb)->state, state); - queue_work_on(cpumask_choose_online(&peer->serial_work_cpu, peer->internal_id), peer->device->packet_crypt_wq, &queue->work); - peer_put(peer); + queue_work_on(cpumask_choose_online(&PACKET_PEER(skb)->serial_work_cpu, PACKET_PEER(skb)->internal_id), PACKET_PEER(skb)->device->packet_crypt_wq, &queue->work); } static inline void queue_enqueue_per_peer_napi(struct crypt_queue *queue, struct sk_buff *skb, enum packet_state state) { - struct wireguard_peer *peer = peer_rcu_get(PACKET_PEER(skb)); - atomic_set(&PACKET_CB(skb)->state, state); - napi_schedule(&peer->napi); - peer_put(peer); + napi_schedule(&PACKET_PEER(skb)->napi); } #ifdef DEBUG |