diff options
| author |   kurt <kurt@openbsd.org> | 2009-11-09 00:18:27 +0000 |
|---|---|---|
| committer | kurt <kurt@openbsd.org> | 2009-11-09 00:18:27 +0000 |
| commit | c5acf43a359ac8e21498420ba26e0d56c2821a31 (patch) | |
| tree | aea05e2f1bc3a9156f2e6099880b0eb623c7e4e5 /lib/libc/stdio/fclose.c | |
| parent | forwards_get() also calls alias_to_expand_node() (diff) | |
| download | wireguard-openbsd-c5acf43a359ac8e21498420ba26e0d56c2821a31.tar.xz wireguard-openbsd-c5acf43a359ac8e21498420ba26e0d56c2821a31.zip | |
Fix the handle locking in stdio to use flockfile/funlockfile
internally when and where required. Macros in <stdio.h> are updated
to automatically call the underlying functions when the process is
threaded to obtain the necessary locking. A private mutex is added
to protect __sglue, the internal list of FILE handles, and another
to protect the one-time initialization. Some routines in libc that
use getc() change to use getc_unlocked() as they're either protected
by their own lock or aren't thread-safe routines anyway.
committing on behalf of and okay guenther@ now that we have install
media space available.
Diffstat (limited to 'lib/libc/stdio/fclose.c')
| -rw-r--r-- | lib/libc/stdio/fclose.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/libc/stdio/fclose.c b/lib/libc/stdio/fclose.c index 98e9826b82c..c72af540586 100644 --- a/lib/libc/stdio/fclose.c +++ b/lib/libc/stdio/fclose.c @@ -1,4 +1,4 @@ -/* $OpenBSD: fclose.c,v 1.8 2009/10/22 01:23:16 guenther Exp $ */ +/* $OpenBSD: fclose.c,v 1.9 2009/11/09 00:18:27 kurt Exp $ */ /*- * Copyright (c) 1990, 1993 * The Regents of the University of California. All rights reserved. @@ -45,6 +45,7 @@ fclose(FILE *fp) errno = EBADF; return (EOF); } + FLOCKFILE(fp); WCIO_FREE(fp); r = fp->_flags & __SWR ? __sflush(fp) : 0; if (fp->_close != NULL && (*fp->_close)(fp->_cookie) < 0) @@ -55,7 +56,8 @@ fclose(FILE *fp) FREEUB(fp); if (HASLB(fp)) FREELB(fp); - fp->_flags = 0; /* Release this FILE for reuse. */ fp->_r = fp->_w = 0; /* Mess up if reaccessed. */ + fp->_flags = 0; /* Release this FILE for reuse. */ + FUNLOCKFILE(fp); return (r); } |