summaryrefslogtreecommitdiffstats
path: root/sys/dev/rasops/rasops.c
diff options
context:
space:
mode:
authordlg <dlg@openbsd.org>2015-01-27 03:17:35 +0000
committerdlg <dlg@openbsd.org>2015-01-27 03:17:35 +0000
commite419548092f59c20a140404818050eb2ab331a19 (patch)
treeff250435e8b28c07c967073741c21d374241b774 /sys/dev/rasops/rasops.c
parentRemove an unused and confusing assignment that had been commented out for (diff)
downloadwireguard-openbsd-e419548092f59c20a140404818050eb2ab331a19.tar.xz
wireguard-openbsd-e419548092f59c20a140404818050eb2ab331a19.zip
remove the second void * argument on tasks.
when workqs were introduced, we provided a second argument so you could pass a thing and some context to work on it in. there were very few things that took advantage of the second argument, so when i introduced pools i suggested removing it. since tasks were meant to replace workqs, it was requested that we keep the second argument to make porting from workqs to tasks easier. now that workqs are gone, i had a look at the use of the second argument again and found only one good use of it (vdsp(4) on sparc64 if you're interested) and a tiny handful of questionable uses. the vast majority of tasks only used a single argument. i have since modified all tasks that used two args to only use one, so now we can remove the second argument. so this is a mechanical change. all tasks only passed NULL as their second argument, so we can just remove it. ok krw@
Diffstat (limited to 'sys/dev/rasops/rasops.c')
-rw-r--r--sys/dev/rasops/rasops.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/sys/dev/rasops/rasops.c b/sys/dev/rasops/rasops.c
index 6dae03cb11d..e0a59558d1d 100644
--- a/sys/dev/rasops/rasops.c
+++ b/sys/dev/rasops/rasops.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: rasops.c,v 1.37 2014/12/22 20:08:05 krw Exp $ */
+/* $OpenBSD: rasops.c,v 1.38 2015/01/27 03:17:36 dlg Exp $ */
/* $NetBSD: rasops.c,v 1.35 2001/02/02 06:01:01 marcus Exp $ */
/*-
@@ -164,7 +164,7 @@ struct rotatedfont {
};
#endif
-void rasops_doswitch(void *, void *);
+void rasops_doswitch(void *);
int rasops_vcons_cursor(void *, int, int, int);
int rasops_vcons_mapchar(void *, int, u_int *);
int rasops_vcons_putchar(void *, int, int, u_int, long);
@@ -274,7 +274,7 @@ rasops_init(struct rasops_info *ri, int wantrows, int wantcols)
ri->ri_ops.unpack_attr = rasops_vcons_unpack_attr;
}
- task_set(&ri->ri_switchtask, rasops_doswitch, ri, NULL);
+ task_set(&ri->ri_switchtask, rasops_doswitch, ri);
rasops_init_devcmap(ri);
return (0);
@@ -1435,12 +1435,12 @@ rasops_show_screen(void *v, void *cookie, int waitok,
return (EAGAIN);
}
- rasops_doswitch(ri, NULL);
+ rasops_doswitch(ri);
return (0);
}
void
-rasops_doswitch(void *v, void *dummy)
+rasops_doswitch(void *v)
{
struct rasops_info *ri = v;
struct rasops_screen *scr = ri->ri_switchcookie;