diff options
author | natano <natano@openbsd.org> | 2016-03-19 12:04:15 +0000 |
---|---|---|
committer | natano <natano@openbsd.org> | 2016-03-19 12:04:15 +0000 |
commit | 937fcae7c622e0ae47c1757467b994983f2677fb (patch) | |
tree | 67fb7013ab6a41111d228055d032a29f68d1516d /sys/msdosfs | |
parent | Reduces the noise around the global ``ticks'' variable by renaming all (diff) | |
download | wireguard-openbsd-937fcae7c622e0ae47c1757467b994983f2677fb.tar.xz wireguard-openbsd-937fcae7c622e0ae47c1757467b994983f2677fb.zip |
Remove the unused flags argument from VOP_UNLOCK().
torture tested on amd64, i386 and macppc
ok beck mpi stefan
"the change looks right" deraadt
Diffstat (limited to 'sys/msdosfs')
-rw-r--r-- | sys/msdosfs/msdosfs_denode.c | 4 | ||||
-rw-r--r-- | sys/msdosfs/msdosfs_lookup.c | 12 | ||||
-rw-r--r-- | sys/msdosfs/msdosfs_vfsops.c | 14 | ||||
-rw-r--r-- | sys/msdosfs/msdosfs_vnops.c | 24 |
4 files changed, 27 insertions, 27 deletions
diff --git a/sys/msdosfs/msdosfs_denode.c b/sys/msdosfs/msdosfs_denode.c index cdb15695617..1009a8a6795 100644 --- a/sys/msdosfs/msdosfs_denode.c +++ b/sys/msdosfs/msdosfs_denode.c @@ -1,4 +1,4 @@ -/* $OpenBSD: msdosfs_denode.c,v 1.55 2015/10/23 17:21:34 krw Exp $ */ +/* $OpenBSD: msdosfs_denode.c,v 1.56 2016/03/19 12:04:16 natano Exp $ */ /* $NetBSD: msdosfs_denode.c,v 1.23 1997/10/17 11:23:58 ws Exp $ */ /*- @@ -661,7 +661,7 @@ msdosfs_inactive(void *v) deupdat(dep, 0); out: - VOP_UNLOCK(vp, 0, p); + VOP_UNLOCK(vp, p); /* * If we are done with the denode, reclaim it * so that it can be reused immediately. diff --git a/sys/msdosfs/msdosfs_lookup.c b/sys/msdosfs/msdosfs_lookup.c index ddd293482e1..fcb7f2d7a7e 100644 --- a/sys/msdosfs/msdosfs_lookup.c +++ b/sys/msdosfs/msdosfs_lookup.c @@ -1,4 +1,4 @@ -/* $OpenBSD: msdosfs_lookup.c,v 1.29 2015/10/23 17:21:34 krw Exp $ */ +/* $OpenBSD: msdosfs_lookup.c,v 1.30 2016/03/19 12:04:16 natano Exp $ */ /* $NetBSD: msdosfs_lookup.c,v 1.34 1997/10/18 22:12:27 ws Exp $ */ /*- @@ -400,7 +400,7 @@ notfound:; */ cnp->cn_flags |= SAVENAME; if (!lockparent) { - VOP_UNLOCK(vdp, 0, p); + VOP_UNLOCK(vdp, p); cnp->cn_flags |= PDIRUNLOCK; } return (EJUSTRETURN); @@ -491,7 +491,7 @@ foundroot:; return (error); *vpp = DETOV(tdp); if (!lockparent) { - VOP_UNLOCK(vdp, 0, p); + VOP_UNLOCK(vdp, p); cnp->cn_flags |= PDIRUNLOCK; } return (0); @@ -524,7 +524,7 @@ foundroot:; *vpp = DETOV(tdp); cnp->cn_flags |= SAVENAME; if (!lockparent) - VOP_UNLOCK(vdp, 0, p); + VOP_UNLOCK(vdp, p); return (0); } @@ -549,7 +549,7 @@ foundroot:; */ pdp = vdp; if (flags & ISDOTDOT) { - VOP_UNLOCK(pdp, 0, p); /* race to get the inode */ + VOP_UNLOCK(pdp, p); /* race to get the inode */ cnp->cn_flags |= PDIRUNLOCK; if ((error = deget(pmp, cluster, blkoff, &tdp)) != 0) { if (vn_lock(pdp, LK_EXCLUSIVE | LK_RETRY, p) == 0) @@ -572,7 +572,7 @@ foundroot:; if ((error = deget(pmp, cluster, blkoff, &tdp)) != 0) return (error); if (!lockparent || !(flags & ISLASTCN)) { - VOP_UNLOCK(pdp, 0, p); + VOP_UNLOCK(pdp, p); cnp->cn_flags |= PDIRUNLOCK; } *vpp = DETOV(tdp); diff --git a/sys/msdosfs/msdosfs_vfsops.c b/sys/msdosfs/msdosfs_vfsops.c index ebe94306d02..4edf1875cd6 100644 --- a/sys/msdosfs/msdosfs_vfsops.c +++ b/sys/msdosfs/msdosfs_vfsops.c @@ -1,4 +1,4 @@ -/* $OpenBSD: msdosfs_vfsops.c,v 1.74 2016/03/17 18:52:31 bluhm Exp $ */ +/* $OpenBSD: msdosfs_vfsops.c,v 1.75 2016/03/19 12:04:16 natano Exp $ */ /* $NetBSD: msdosfs_vfsops.c,v 1.48 1997/10/18 02:54:57 briggs Exp $ */ /*- @@ -148,7 +148,7 @@ msdosfs_mount(struct mount *mp, const char *path, void *data, vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, p); error = VOP_ACCESS(devvp, VREAD | VWRITE, p->p_ucred, p); - VOP_UNLOCK(devvp, 0, p); + VOP_UNLOCK(devvp, p); if (error) return (error); } @@ -207,7 +207,7 @@ msdosfs_mount(struct mount *mp, const char *path, void *data, accessmode |= VWRITE; vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, p); error = VOP_ACCESS(devvp, accessmode, p->p_ucred, p); - VOP_UNLOCK(devvp, 0, p); + VOP_UNLOCK(devvp, p); if (error) goto error_devvp; } @@ -302,7 +302,7 @@ msdosfs_mountfs(struct vnode *devvp, struct mount *mp, struct proc *p, return (EBUSY); vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, p); error = vinvalbuf(devvp, V_SAVE, p->p_ucred, p, 0, 0); - VOP_UNLOCK(devvp, 0, p); + VOP_UNLOCK(devvp, p); if (error) return (error); @@ -584,7 +584,7 @@ error_exit: vn_lock(devvp, LK_EXCLUSIVE|LK_RETRY, p); (void) VOP_CLOSE(devvp, ronly ? FREAD : FREAD|FWRITE, NOCRED, p); - VOP_UNLOCK(devvp, 0, p); + VOP_UNLOCK(devvp, p); if (pmp) { if (pmp->pm_inusemap) @@ -706,7 +706,7 @@ msdosfs_sync_vnode(struct vnode *vp, void *arg) if ((error = VOP_FSYNC(vp, msa->cred, msa->waitfor, msa->p)) != 0) msa->allerror = error; - VOP_UNLOCK(vp, 0, msa->p); + VOP_UNLOCK(vp, msa->p); vrele(vp); return (0); @@ -748,7 +748,7 @@ msdosfs_sync(struct mount *mp, int waitfor, struct ucred *cred, struct proc *p) vn_lock(pmp->pm_devvp, LK_EXCLUSIVE | LK_RETRY, p); if ((error = VOP_FSYNC(pmp->pm_devvp, cred, waitfor, p)) != 0) msa.allerror = error; - VOP_UNLOCK(pmp->pm_devvp, 0, p); + VOP_UNLOCK(pmp->pm_devvp, p); } return (msa.allerror); diff --git a/sys/msdosfs/msdosfs_vnops.c b/sys/msdosfs/msdosfs_vnops.c index 35115b6876d..534b0827d69 100644 --- a/sys/msdosfs/msdosfs_vnops.c +++ b/sys/msdosfs/msdosfs_vnops.c @@ -1,4 +1,4 @@ -/* $OpenBSD: msdosfs_vnops.c,v 1.108 2016/03/14 23:08:06 krw Exp $ */ +/* $OpenBSD: msdosfs_vnops.c,v 1.109 2016/03/19 12:04:16 natano Exp $ */ /* $NetBSD: msdosfs_vnops.c,v 1.63 1997/10/17 11:24:19 ws Exp $ */ /*- @@ -1003,7 +1003,7 @@ abortit: (fcnp->cn_flags & ISDOTDOT) || (tcnp->cn_flags & ISDOTDOT) || (ip->de_flag & DE_RENAME)) { - VOP_UNLOCK(fvp, 0, p); + VOP_UNLOCK(fvp, p); error = EINVAL; goto abortit; } @@ -1035,7 +1035,7 @@ abortit: * call to doscheckpath(). */ error = VOP_ACCESS(fvp, VWRITE, tcnp->cn_cred, tcnp->cn_proc); - VOP_UNLOCK(fvp, 0, p); + VOP_UNLOCK(fvp, p); if (VTODE(fdvp)->de_StartCluster != VTODE(tdvp)->de_StartCluster) newparent = 1; vrele(fdvp); @@ -1104,7 +1104,7 @@ abortit: if ((fcnp->cn_flags & SAVESTART) == 0) panic("msdosfs_rename: lost from startdir"); if (!newparent) - VOP_UNLOCK(tdvp, 0, p); + VOP_UNLOCK(tdvp, p); (void) vfs_relookup(fdvp, &fvp, fcnp); if (fvp == NULL) { /* @@ -1114,7 +1114,7 @@ abortit: panic("rename: lost dir entry"); vrele(ap->a_fvp); if (newparent) - VOP_UNLOCK(tdvp, 0, p); + VOP_UNLOCK(tdvp, p); vrele(tdvp); return 0; } @@ -1135,7 +1135,7 @@ abortit: panic("rename: lost dir entry"); vrele(ap->a_fvp); if (newparent) - VOP_UNLOCK(fdvp, 0, p); + VOP_UNLOCK(fdvp, p); xp = NULL; } else { vrele(fvp); @@ -1157,7 +1157,7 @@ abortit: if (error) { bcopy(oldname, ip->de_Name, 11); if (newparent) - VOP_UNLOCK(fdvp, 0, p); + VOP_UNLOCK(fdvp, p); goto bad; } ip->de_refcnt++; @@ -1165,7 +1165,7 @@ abortit: if ((error = removede(zp, ip)) != 0) { /* XXX should really panic here, fs is corrupt */ if (newparent) - VOP_UNLOCK(fdvp, 0, p); + VOP_UNLOCK(fdvp, p); goto bad; } @@ -1177,7 +1177,7 @@ abortit: if (error) { /* XXX should really panic here, fs is corrupt */ if (newparent) - VOP_UNLOCK(fdvp, 0, p); + VOP_UNLOCK(fdvp, p); goto bad; } ip->de_diroffset = to_diroffset; @@ -1186,7 +1186,7 @@ abortit: } reinsert(ip); if (newparent) - VOP_UNLOCK(fdvp, 0, p); + VOP_UNLOCK(fdvp, p); } /* @@ -1225,7 +1225,7 @@ abortit: VN_KNOTE(fvp, NOTE_RENAME); bad: - VOP_UNLOCK(fvp, 0, p); + VOP_UNLOCK(fvp, p); vrele(fdvp); bad1: if (xp) @@ -1732,7 +1732,7 @@ msdosfs_unlock(void *v) struct vop_unlock_args *ap = v; struct vnode *vp = ap->a_vp; - return (lockmgr(&VTODE(vp)->de_lock, ap->a_flags | LK_RELEASE, NULL)); + return (lockmgr(&VTODE(vp)->de_lock, LK_RELEASE, NULL)); } int |