diff options
| author |   jsg <jsg@openbsd.org> | 2015-10-20 11:26:40 +0000 |
|---|---|---|
| committer | jsg <jsg@openbsd.org> | 2015-10-20 11:26:40 +0000 |
| commit | fb6469ec318348e9bf0963dcd01c854a59d9bc8b (patch) | |
| tree | 4d9aa49c9b84146de64ceb215c7cd727606e8708 /usr.sbin/eigrpd | |
| parent | On xmalloc failure, stop trying to determine the total amount of allocated (diff) | |
| download | wireguard-openbsd-fb6469ec318348e9bf0963dcd01c854a59d9bc8b.tar.xz wireguard-openbsd-fb6469ec318348e9bf0963dcd01c854a59d9bc8b.zip | |
fix a use after free found by clang using an approach suggested by renato
ok renato@
Diffstat (limited to 'usr.sbin/eigrpd')
| -rw-r--r-- | usr.sbin/eigrpd/rde_dual.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/usr.sbin/eigrpd/rde_dual.c b/usr.sbin/eigrpd/rde_dual.c index a397669233f..f2b782e8df2 100644 --- a/usr.sbin/eigrpd/rde_dual.c +++ b/usr.sbin/eigrpd/rde_dual.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rde_dual.c,v 1.4 2015/10/05 01:59:33 renato Exp $ */ +/* $OpenBSD: rde_dual.c,v 1.5 2015/10/20 11:26:40 jsg Exp $ */ /* * Copyright (c) 2015 Renato Westphal <renato@openbsd.org> @@ -1118,9 +1118,11 @@ rde_check_link_down_rn(struct rde_nbr *nbr, struct rt_node *rn, struct eigrp_route *successor; uint32_t old_fdistance; struct rinfo ri; + enum route_type type; old_fdistance = rn->successor.fdistance; + type = route->type; route_del(rn, route); switch (rn->state) { @@ -1158,7 +1160,7 @@ rde_check_link_down_rn(struct rde_nbr *nbr, struct rt_node *rn, if (rn->state & DUAL_STA_ACTIVE_ALL) { reply = reply_outstanding_find(rn, nbr); if (reply) { - rinfo_fill_infinite(rn, route->type, &ri); + rinfo_fill_infinite(rn, type, &ri); rde_check_reply(nbr, &ri, 0); } } |