summaryrefslogtreecommitdiffstats
path: root/usr.sbin/kvm_mkdb/nlist.c
diff options
context:
space:
mode:
authortedu <tedu@openbsd.org>2003-04-06 23:21:41 +0000
committertedu <tedu@openbsd.org>2003-04-06 23:21:41 +0000
commit82279d24d55b671c34e7032e11451384bdb7ef07 (patch)
treecb21d018b5da4577771a77ee92fd989df3be4816 /usr.sbin/kvm_mkdb/nlist.c
parentkvm_iocache() is not used anymore. (diff)
downloadwireguard-openbsd-82279d24d55b671c34e7032e11451384bdb7ef07.tar.xz
wireguard-openbsd-82279d24d55b671c34e7032e11451384bdb7ef07.zip
use snamesize and realloc properly. ok tdeval@
Diffstat (limited to 'usr.sbin/kvm_mkdb/nlist.c')
-rw-r--r--usr.sbin/kvm_mkdb/nlist.c22
1 files changed, 13 insertions, 9 deletions
diff --git a/usr.sbin/kvm_mkdb/nlist.c b/usr.sbin/kvm_mkdb/nlist.c
index 5768a81e314..cb3d88e58d3 100644
--- a/usr.sbin/kvm_mkdb/nlist.c
+++ b/usr.sbin/kvm_mkdb/nlist.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: nlist.c,v 1.31 2003/04/04 22:40:52 deraadt Exp $ */
+/* $OpenBSD: nlist.c,v 1.32 2003/04/06 23:21:41 tedu Exp $ */
/*-
* Copyright (c) 1990, 1993
@@ -37,7 +37,7 @@
#if 0
static char sccsid[] = "from: @(#)nlist.c 8.1 (Berkeley) 6/6/93";
#else
-static char *rcsid = "$OpenBSD: nlist.c,v 1.31 2003/04/04 22:40:52 deraadt Exp $";
+static const char rcsid[] = "$OpenBSD: nlist.c,v 1.32 2003/04/06 23:21:41 tedu Exp $";
#endif
#endif /* not lint */
@@ -171,12 +171,14 @@ __aout_knlist(fd, db, ksyms)
p = strtab + nbuf._strx - sizeof(int);
if (*p != '_') {
len = strlen(p) + 1;
- if (len >= snamesize)
- sname = realloc(sname, len + 1024);
+ if (len >= snamesize) {
+ snamesize = len + 1024;
+ sname = realloc(sname, snamesize);
+ }
if (sname == NULL)
errx(1, "cannot allocate memory");
*sname = '_';
- strlcpy(sname+1, p, len);
+ strlcpy(sname + 1, p, snamesize - 1);
key.data = (u_char *)sname;
key.size = len;
} else {
@@ -448,7 +450,7 @@ __elf_knlist(fd, db, ksyms)
nbuf.n_type = N_FN;
break;
}
- if(ELF_ST_BIND(sbuf.st_info) == STB_LOCAL)
+ if (ELF_ST_BIND(sbuf.st_info) == STB_LOCAL)
nbuf.n_type = N_EXT;
*buf = '_';
@@ -606,13 +608,15 @@ __ecoff_knlist(fd, db, ksyms)
for (sname = NULL, i = 0; i < nesyms; i++) {
/* Need to prepend a '_' */
len = strlen(&mappedfile[extstroff + esyms[i].es_strindex]) + 1;
- if (len >= snamesize)
- sname = realloc(sname, len + 1024);
+ if (len >= snamesize) {
+ snamesize = len + 1024;
+ sname = realloc(sname, snamesize);
+ }
if (sname == NULL)
errx(1, "cannot allocate memory");
*sname = '_';
strlcpy(sname+1, &mappedfile[extstroff + esyms[i].es_strindex],
- len - 1);
+ snamesize - 1);
/* Fill in NLIST */
bzero(&nbuf, sizeof(nbuf));