diff options
| author |   krw <krw@openbsd.org> | 2018-07-09 12:05:10 +0000 |
|---|---|---|
| committer | krw <krw@openbsd.org> | 2018-07-09 12:05:10 +0000 |
| commit | 6a3d55f939083b5d9457342b25519eade91f9c38 (patch) | |
| tree | 188f28c742c46075222046ad71a98373cd17f78e /usr.sbin/ldpd | |
| parent | Extend the v4_defroute() function description and make the fallback to (diff) | |
| download | wireguard-openbsd-6a3d55f939083b5d9457342b25519eade91f9c38.tar.xz wireguard-openbsd-6a3d55f939083b5d9457342b25519eade91f9c38.zip | |
No need to mention which memory allocation entry point failed (malloc,
calloc or strdup), we just need to log that we ran out of memory in a
particular function.
Recommended by florian@ and deraadt@
ok benno@ henning@ tb@
Diffstat (limited to 'usr.sbin/ldpd')
| -rw-r--r-- | usr.sbin/ldpd/parse.y | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/usr.sbin/ldpd/parse.y b/usr.sbin/ldpd/parse.y index a638b6a4c5d..ff2aa801e6d 100644 --- a/usr.sbin/ldpd/parse.y +++ b/usr.sbin/ldpd/parse.y @@ -1,4 +1,4 @@ -/* $OpenBSD: parse.y,v 1.63 2018/06/11 09:34:46 denis Exp $ */ +/* $OpenBSD: parse.y,v 1.64 2018/07/09 12:05:11 krw Exp $ */ /* * Copyright (c) 2013, 2015, 2016 Renato Westphal <renato@openbsd.org> @@ -1160,16 +1160,16 @@ pushfile(const char *name, int secret) struct file *nfile; if ((nfile = calloc(1, sizeof(struct file))) == NULL) { - log_warn("calloc"); + log_warn("%s", __func__); return (NULL); } if ((nfile->name = strdup(name)) == NULL) { - log_warn("strdup"); + log_warn("%s", __func__); free(nfile); return (NULL); } if ((nfile->stream = fopen(nfile->name, "r")) == NULL) { - log_warn("%s", nfile->name); + log_warn("%s: %s", __func__, nfile->name); free(nfile->name); free(nfile); return (NULL); @@ -1184,7 +1184,7 @@ pushfile(const char *name, int secret) nfile->ungetsize = 16; nfile->ungetbuf = malloc(nfile->ungetsize); if (nfile->ungetbuf == NULL) { - log_warn("malloc"); + log_warn("%s", __func__); fclose(nfile->stream); free(nfile->name); free(nfile); |