diff options
| author |   deraadt <deraadt@openbsd.org> | 2019-06-28 13:32:41 +0000 |
|---|---|---|
| committer | deraadt <deraadt@openbsd.org> | 2019-06-28 13:32:41 +0000 |
| commit | df69c215c7c66baf660f3f65414fd34796c96152 (patch) | |
| tree | 0255639162b24c4a2f761a274e32b69c2256fd45 /usr.sbin/lpd | |
| parent | miniroot prototype disklabels should attempt to contain accurate (diff) | |
| download | wireguard-openbsd-df69c215c7c66baf660f3f65414fd34796c96152.tar.xz wireguard-openbsd-df69c215c7c66baf660f3f65414fd34796c96152.zip | |
When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
Diffstat (limited to 'usr.sbin/lpd')
| -rw-r--r-- | usr.sbin/lpd/lpd.c | 4 | ||||
| -rw-r--r-- | usr.sbin/lpd/parse.y | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/usr.sbin/lpd/lpd.c b/usr.sbin/lpd/lpd.c index fbbe5a7069e..01b5760cdc6 100644 --- a/usr.sbin/lpd/lpd.c +++ b/usr.sbin/lpd/lpd.c @@ -1,4 +1,4 @@ -/* $OpenBSD: lpd.c,v 1.1.1.1 2018/04/27 16:14:37 eric Exp $ */ +/* $OpenBSD: lpd.c,v 1.2 2019/06/28 13:32:48 deraadt Exp $ */ /* * Copyright (c) 2017 Eric Faurot <eric@openbsd.org> @@ -313,7 +313,7 @@ priv_open_listener(struct listener *l) case AF_INET6: opt = 1; if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &opt, - sizeof(opt)) < 0) + sizeof(opt)) == -1) fatal("setsockopt: %s", log_fmt_sockaddr(sa)); if (bind(sock, sa, sa->sa_len) == -1) diff --git a/usr.sbin/lpd/parse.y b/usr.sbin/lpd/parse.y index 123a294dda0..e22ddb3d9ee 100644 --- a/usr.sbin/lpd/parse.y +++ b/usr.sbin/lpd/parse.y @@ -1,4 +1,4 @@ -/* $OpenBSD: parse.y,v 1.6 2019/02/13 22:57:08 deraadt Exp $ */ +/* $OpenBSD: parse.y,v 1.7 2019/06/28 13:32:48 deraadt Exp $ */ /* * Copyright (c) 2008 Gilles Chehade <gilles@poolp.org> @@ -936,7 +936,7 @@ is_if_in_group(const char *ifname, const char *groupname) int s; int ret = 0; - if ((s = socket(AF_INET, SOCK_DGRAM, 0)) < 0) + if ((s = socket(AF_INET, SOCK_DGRAM, 0)) == -1) err(1, "socket"); memset(&ifgr, 0, sizeof(ifgr)); |