summaryrefslogtreecommitdiffstats
path: root/usr.sbin/npppd
diff options
context:
space:
mode:
authorkrw <krw@openbsd.org>2018-07-09 12:05:10 +0000
committerkrw <krw@openbsd.org>2018-07-09 12:05:10 +0000
commit6a3d55f939083b5d9457342b25519eade91f9c38 (patch)
tree188f28c742c46075222046ad71a98373cd17f78e /usr.sbin/npppd
parentExtend the v4_defroute() function description and make the fallback to (diff)
downloadwireguard-openbsd-6a3d55f939083b5d9457342b25519eade91f9c38.tar.xz
wireguard-openbsd-6a3d55f939083b5d9457342b25519eade91f9c38.zip
No need to mention which memory allocation entry point failed (malloc,
calloc or strdup), we just need to log that we ran out of memory in a particular function. Recommended by florian@ and deraadt@ ok benno@ henning@ tb@
Diffstat (limited to 'usr.sbin/npppd')
-rw-r--r--usr.sbin/npppd/npppd/parse.y8
1 files changed, 4 insertions, 4 deletions
diff --git a/usr.sbin/npppd/npppd/parse.y b/usr.sbin/npppd/npppd/parse.y
index 1c7042f3cae..ca620782175 100644
--- a/usr.sbin/npppd/npppd/parse.y
+++ b/usr.sbin/npppd/npppd/parse.y
@@ -1,4 +1,4 @@
-/* $OpenBSD: parse.y,v 1.20 2018/07/08 17:15:07 krw Exp $ */
+/* $OpenBSD: parse.y,v 1.21 2018/07/09 12:05:11 krw Exp $ */
/*
* Copyright (c) 2002, 2003, 2004 Henning Brauer <henning@openbsd.org>
@@ -1329,11 +1329,11 @@ pushfile(const char *name)
struct file *nfile;
if ((nfile = calloc(1, sizeof(struct file))) == NULL) {
- log_warn("calloc");
+ log_warn("%s", __func__);
return (NULL);
}
if ((nfile->name = strdup(name)) == NULL) {
- log_warn("strdup");
+ log_warn("%s", __func__);
free(nfile);
return (NULL);
}
@@ -1342,7 +1342,7 @@ pushfile(const char *name)
#else
if ((nfile->stream = priv_fopen(nfile->name)) == NULL) {
#endif
- log_warn("%s", nfile->name);
+ log_warn("%s: %s", __func__, nfile->name);
free(nfile->name);
free(nfile);
return (NULL);