diff options
| author |   miko <miko@openbsd.org> | 2018-09-07 07:35:30 +0000 |
|---|---|---|
| committer | miko <miko@openbsd.org> | 2018-09-07 07:35:30 +0000 |
| commit | ed1b9eb881714d81d85f14afa35f51254e80d5b6 (patch) | |
| tree | a7e9c90d1e807274ba7f0b178c37c63c7b6aea46 /usr.sbin/snmpd | |
| parent | Fix "_nfiles" reference for crash dump. (diff) | |
| download | wireguard-openbsd-ed1b9eb881714d81d85f14afa35f51254e80d5b6.tar.xz wireguard-openbsd-ed1b9eb881714d81d85f14afa35f51254e80d5b6.zip | |
replace malloc()+strlcpy() with strndup() in cmdline_symset().
"looks good" gilles@ halex@
Diffstat (limited to 'usr.sbin/snmpd')
| -rw-r--r-- | usr.sbin/snmpd/parse.y | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/usr.sbin/snmpd/parse.y b/usr.sbin/snmpd/parse.y index f4ac69a1701..f9a878b7828 100644 --- a/usr.sbin/snmpd/parse.y +++ b/usr.sbin/snmpd/parse.y @@ -1,4 +1,4 @@ -/* $OpenBSD: parse.y,v 1.51 2018/07/11 07:39:22 krw Exp $ */ +/* $OpenBSD: parse.y,v 1.52 2018/09/07 07:35:31 miko Exp $ */ /* * Copyright (c) 2007, 2008, 2012 Reyk Floeter <reyk@openbsd.org> @@ -1127,17 +1127,12 @@ cmdline_symset(char *s) { char *sym, *val; int ret; - size_t len; if ((val = strrchr(s, '=')) == NULL) return (-1); - - len = strlen(s) - strlen(val) + 1; - if ((sym = malloc(len)) == NULL) - errx(1, "cmdline_symset: malloc"); - - (void)strlcpy(sym, s, len); - + sym = strndup(s, val - s); + if (sym == NULL) + errx(1, "%s: strndup", __func__); ret = symset(sym, val + 1, 1); free(sym); |