summaryrefslogtreecommitdiffstats
path: root/usr.sbin/tcpdump/print-icmp.c
diff options
context:
space:
mode:
authorderaadt <deraadt@openbsd.org>2015-01-16 06:39:28 +0000
committerderaadt <deraadt@openbsd.org>2015-01-16 06:39:28 +0000
commitb9fc9a728fce9c4289b7e9a992665e28d5629a54 (patch)
tree72b2433e418dfa1aef5fcf8305617b97979a25d8 /usr.sbin/tcpdump/print-icmp.c
parentimprove checksum parsing slightly. now handles filenames with spaces. (diff)
downloadwireguard-openbsd-b9fc9a728fce9c4289b7e9a992665e28d5629a54.tar.xz
wireguard-openbsd-b9fc9a728fce9c4289b7e9a992665e28d5629a54.zip
Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
Diffstat (limited to 'usr.sbin/tcpdump/print-icmp.c')
-rw-r--r--usr.sbin/tcpdump/print-icmp.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/usr.sbin/tcpdump/print-icmp.c b/usr.sbin/tcpdump/print-icmp.c
index a693aea3c42..fe967c5088b 100644
--- a/usr.sbin/tcpdump/print-icmp.c
+++ b/usr.sbin/tcpdump/print-icmp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: print-icmp.c,v 1.24 2014/08/14 12:44:44 mpi Exp $ */
+/* $OpenBSD: print-icmp.c,v 1.25 2015/01/16 06:40:21 deraadt Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1991, 1993, 1994, 1995, 1996
@@ -21,7 +21,6 @@
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
*/
-#include <sys/param.h>
#include <sys/time.h>
#include <sys/socket.h>
@@ -40,6 +39,7 @@ struct rtentry;
#include <stdio.h>
#include <string.h>
+#include <limits.h>
#include "interface.h"
#include "addrtoname.h"
@@ -171,8 +171,8 @@ icmp_print(const u_char *bp, u_int length, const u_char *bp2)
const struct ip *oip;
const struct udphdr *ouh;
u_int hlen, dport, mtu;
- char buf[MAXHOSTNAMELEN+256];
- char buf2[MAXHOSTNAMELEN+256];
+ char buf[HOST_NAME_MAX+1+256];
+ char buf2[HOST_NAME_MAX+1+256];
dp = (struct icmp *)bp;
ip = (struct ip *)bp2;