diff options
| author |   mestre <mestre@openbsd.org> | 2017-05-12 18:03:00 +0000 |
|---|---|---|
| committer | mestre <mestre@openbsd.org> | 2017-05-12 18:03:00 +0000 |
| commit | 4f8d17899dd3dd61da4cf6c014d8c0396483cc96 (patch) | |
| tree | 7d73975ee47a246a98a57a41ecc9cfb0f506dc2b /usr.sbin/user | |
| parent | Make the tag column in .Bl -tag lists wider: (diff) | |
| download | wireguard-openbsd-4f8d17899dd3dd61da4cf6c014d8c0396483cc96.tar.xz wireguard-openbsd-4f8d17899dd3dd61da4cf6c014d8c0396483cc96.zip | |
Replace memset(3) with explicit_bzero(3) on user(8) on sensitive data
(passwords) as soon as they are not needed on memory anymore.
OK millert@
Diffstat (limited to 'usr.sbin/user')
| -rw-r--r-- | usr.sbin/user/user.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/usr.sbin/user/user.c b/usr.sbin/user/user.c index c273528a18c..8ec98be3bb7 100644 --- a/usr.sbin/user/user.c +++ b/usr.sbin/user/user.c @@ -1,4 +1,4 @@ -/* $OpenBSD: user.c,v 1.118 2016/11/30 23:58:07 mestre Exp $ */ +/* $OpenBSD: user.c,v 1.119 2017/05/12 18:03:00 mestre Exp $ */ /* $NetBSD: user.c,v 1.69 2003/04/14 17:40:07 agc Exp $ */ /* @@ -1359,7 +1359,7 @@ moduser(char *login_name, char *newlogin, user_t *up) up->u_flags |= F_PASSWORD; memsave(&up->u_password, pwp->pw_passwd, strlen(pwp->pw_passwd)); - memset(pwp->pw_passwd, 'X', strlen(pwp->pw_passwd)); + explicit_bzero(pwp->pw_passwd, strlen(pwp->pw_passwd)); } } endpwent(); @@ -1788,7 +1788,7 @@ useradd(int argc, char **argv) break; case 'p': memsave(&u.u_password, optarg, strlen(optarg)); - memset(optarg, 'X', strlen(optarg)); + explicit_bzero(optarg, strlen(optarg)); break; case 'r': defaultfield = 1; @@ -1929,7 +1929,7 @@ usermod(int argc, char **argv) break; case 'p': memsave(&u.u_password, optarg, strlen(optarg)); - memset(optarg, 'X', strlen(optarg)); + explicit_bzero(optarg, strlen(optarg)); u.u_flags |= F_PASSWORD; break; case 's': |