summaryrefslogtreecommitdiffstats
path: root/lib/libc/stdio
AgeCommit message (Collapse)AuthorFilesLines
2019-12-03fwide() does not unlock if error was occurred.asou1-2/+4
ok guenther@ and deraadt
2019-09-07more Version 1 AT&T UNIX history:schwarze1-3/+7
a few cases that weren't altogether straightforward; tweak and OK jmc@, OK sobrado@
2019-08-30.Dt same as filenamederaadt1-3/+3
2019-08-30mop up stdarg rename; ok deraadtjmc4-12/+12
2019-06-29two more syscall == -1 checksderaadt1-3/+3
2019-06-28Specify that {v,}asprintf(3) returns precisely -1 on failure,schwarze1-7/+11
and that the ret pointer is either unchanged or set to NULL in this case. Since these two functions are not standardized by POSIX, documenting the actual behaviour is the way to go, and the above matches all non-buggy implementations we are aware of. OK millert@ deraadt@
2019-06-28When system calls indicate an error they return -1, not some arbitraryderaadt5-11/+11
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-06-27Simplify the description of [v]snprintf(3), move the descriptionschwarze1-19/+18
of the return values to RETURN VALUES, deprecate [v]sprintf(3) and fix a punctuation typo. Joint work with and OK millert@.
2019-06-26an -> a;jmc1-2/+2
2019-06-26The POSIX-compatible way of checking for {v,}{f,s,sn,d}printf(3)deraadt1-4/+5
failure is with < 0, not the more specific -1 from C discussed at length with millert, nicm, schwarze
2019-05-16More consistently put remarks about the less useful LC_* categoties,schwarze1-3/+13
i.e. those other than LC_CTYPE, into the CAVEATS section, and standardize wording somewhat. OK jmc@
2019-05-02Fix a comparison in open_memstream not to confuse when a negativeyasuoka1-3/+3
value is given for the off. found by nagasaka at IIJ. ok deraadt
2019-04-26Undo changes to tmpfile.c r1.5.martijn2-26/+5
Doing the fchown call causes pledge("tmppath") to be insufficient and the the umask dance may cause race-conditions in multithreaded applications. Also POSIX states the following nowadays: implementations may restrict the permissions, either by clearing the file mode bits or setting them to the value S_IRUSR | S_IWUSR. Encouraging words from tedu@ Standards verification and OK millert@
2019-03-03in vdprintf(), no need to use the file locking mecanism when usingsemarie1-2/+2
fflush() as the variable is stack based (no possible concurrent access). call directly __sflush() ok visa@ deraadt@
2019-01-25I am retiring my old email address; replace it with my OpenBSD one.millert3-6/+6
2019-01-16For all functions known to be infected by LC_NUMERIC, add shortschwarze4-29/+30
CAVEATS pointing to the new CAVEATS section in setlocale(3). Make those in wprintf(3) and wscanf(3) more concise since duplicate information is a bad idea. Incompleteness of information originally pointed out by millert@. OK millert@
2019-01-11Similar CAVEATS regarding LC_NUMERIC as was just committedschwarze1-6/+19
to wprintf(3) with OK cheloha@ tedu@; also triggered by a smaller diff from Jan Stary <hans at stare dot cz>.
2019-01-11Clarify that OpenBSD ignores the dangerous category LC_NUMERIC,schwarze1-16/+30
and explain best practice for portable programs below CAVEATS. Triggered by a smaller diff from Jan Stary <hans at stare dot cz>. Emphatic OKs from cheloha@ and tedu@.
2018-12-16Restore the optimization for unbuffered I/O. The buffer needs tomillert1-1/+31
be reset before each call to __srefill(). Passes new regress. OK semarie@
2018-12-16Back out rev 1.17 for now, it causes issues with python when buildingmillert1-31/+1
databases/tdb from ports.
2018-12-14Revisit the optimization for unbuffered I/O. We can use the buffermillert1-1/+31
passed to fread(3) directly in the FILE * and call __srefill() in a loop without the memcpy(). This preserves the expected behavior in all cases. OK semarie@, "This is neat" tedu@
2018-12-14Back out the optimization in rev 1.13, it does not update flags onmillert1-16/+1
EOF or error. This caused a regression in the cPickle python extension.
2018-01-02some grammar fixes; from dholland@netbsd, -r1.68jmc1-6/+6
2017-12-08Fix the return value of fwscanf(3) when encountering an early matchingkevlo1-2/+2
failure. This change brings fwscanf(3) back in line with fscanf(3). From FreeBSD; ok deraadt@, millert@
2017-12-01Consistently .Xr the corresponding wide char functions from char- andschwarze11-26/+37
string-handling <stdio.h> functions, like we already do it for <string.h>. Includes a smaller patch from <kshe59 at zoho dot eu>, OK jmc@.
2017-12-01add missing argument name; from <kshe59 at zoho dot eu>; OK jmc@;schwarze1-8/+32
while here, consistently use .Fo to cure execessive line lengths
2017-11-28GNU ld has prefixed the contents of .gnu.warning.SYMBOL sectionstb5-10/+10
with "warning: " since 2003, so the messages themselves need not contain the prefix anymore. From Scott Cheloha ok jca, deraadt
2017-11-21Use a simple forward search to find '%' in the format string instead oftb1-35/+12
using mbrtowc(3). Thus, we now treat the format string as a bytestring, not as a multibyte character string. We think that ANSI C made a small error when adding wide characters: The committees essentially replaced "characters" with "wide characters" in the existing printf documentation, which was written before the concept of processing was established. Doing processing on the format string would break some 8-bit format strings in the wild, and that isn't something these committees gave themselves license to do. Based on the "10x printf speedup" commit from android found by tedu: https://github.com/aosp-mirror/platform_bionic/commit/5305a4d4a723b06494b93f2df81733b83a0c46d3 Thanks to millert and schwarze for digging into the history and testing *printf behavior on other platforms. ok deraadt, millert
2017-11-16Add error checking to some calls to __find_arguments(). Matches similartb1-6/+16
changes by schwarze to vfprintf.c r1.71. Cherrypicked from android: https://github.com/aosp-mirror/platform_bionic/commit/5305a4d4a723b06494b93f2df81733b83a0c46d3 ok millert
2017-10-17add missing HISTORY; based on CVS logs and release announcementsschwarze1-2/+7
2017-08-15fmt0 is a wchar_t *, so use %ls to reportderaadt1-3/+3
2017-07-22Favor err() over perror() in example.anton1-3/+3
ok schwarze@
2017-07-041. mild deprecation noticeschwarze1-3/+11
2. point to getline (suggested by nicm@) 3. cross reference fgetc(3) rather than putc(3) 4. add missing error handling to the example code OK nicm@
2017-06-12Add dprintf() and vdprintf() RETURN VALUES. OK deraadt@millert1-2/+4
2017-04-13Use recallocarray in getdelim/getline to clear memory on buffer resizes,brynet1-2/+2
inspired by a similar change to fgetln. ok deraadt millert
2017-03-17Use recallocarray() to avoid leaving detritus in memory when resizingmillert1-2/+3
the string buffer used by asprintf() and vasprintf(). OK deraadt@
2017-03-17Use recallocarray() to avoid leaving detritus in memory when resizingderaadt4-8/+12
buffers. We don't bother doing this for objects containing pointers, but focus on controllable data. ok millert
2017-03-16Only reallocate the buffer to fit for medium-size allocations wheremillert2-18/+28
we expanded the buffer to a single page. The final realloc() can be expensive for large buffers and is not realled needed. OK deraadt@
2017-03-16When reallocating the buffer for asprintf(), just round up to themillert1-6/+5
nearest page instead of doubling the old size until it is large enough. OK deraadt@
2017-03-14Use a macro for the initial length of the buffer instead of 127; OK deraadt@millert2-6/+10
2016-10-30include float.h for the LDBL_MAX_EXP cpp test in floatio.hjsg2-2/+4
2016-09-21Delete casts to off_t and size_t that are implied by assignmentsguenther14-42/+39
or prototypes. Ditto for some of the char* and void* casts too. verified no change to instructions on ILP32 (i386) and LP64 (amd64) ok natano@ abluhm@ deraadt@ millert@
2016-08-29Store the return value of mbrtowc() in a size_t, not int.millert1-13/+15
OK schwarze@
2016-08-27Stop recommending the non-standard and slightly dangerous fgetln(3).schwarze1-4/+4
Recommend POSIX getline(3) instead.
2016-08-27When a precision is specified for a string format use strnlen()millert1-17/+7
to determine the length instead of doing it manually. OK schwarze@
2016-08-27improve revision 1.2: in unusual cases, fgetwc(3) can succeedschwarze1-2/+12
even though ferror(3) is already set; also from Andrey Chernov <ache at freebsd dot org>; OK millert@
2016-08-25After read errors, fgetln(3) sometimes succeeded (returning non-NULL)schwarze1-3/+6
and failed (setting errno and ferror(3)) both at the same time. That's a bad idea in general, and here in particular since returning partial lines was neither reliable (sometimes, you got NULL anyway) nor predictable (almost always, the line would be truncated long before the actual read error). Instead, on read failure, fail properly and always return NULL. Issue found in a discussion with Andrey Chernov <ache at freebsd dot org> who finally agreed to move FreeBSD into the same direction. The fix is joint work with and OK by millert@.
2016-08-24set the error indicator on malloc(3) failure;schwarze1-2/+4
from Andrey Chernov <ache at freebsd dot org>; OK millert@
2016-08-21bugfix: when fgetwc(3) fails, fgetwln(3) must fail as well;schwarze1-2/+2
OK jca@ martijn@ millert@
2016-08-17% is escaped with more %, not backslash.tedu2-6/+6
Copyright © 1996 – 2026 Jason A. Donenfeld. All Rights Reverse Engineered.