| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
So instead, do the kbind disabling with syscall().
debugging and ok deraadt@, ok kettenis@
|
|
|
|
|
|
| |
so no need to include share/locale/ctype/Makefile.inc to get it.
ok guenther@ stsp@ (who had the same diff)
|
|
|
|
| |
ok jmc
|
|
|
|
| |
address of the new thread
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
move their definitions and initialization in static links to libc.a
Make crt0 always invoke a new func _csu_finish() in libc to process the auxv
and to either register the ld.so cleanup function (in dynamic links) or
initialize environ and __progname and do MC_DISABLE_KBIND (in static links).
In libc, get pagesize from auxv; cache that between getpagesize() and
sysconf(_SC_PAGESIZE)
ok mpi@ "good time" deraadt@
|
|
|
|
|
|
|
|
|
|
| |
idioms.
Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0)
where it is obvious further investigation will not yield and
even better way.
Obviousness evaluation and ok guenther@
|
| |
|
| |
|
| |
|
|
|
|
| |
ok otto@
|
|
|
|
| |
okay jmc@
|
|
|
|
| |
ok @stefan armani@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
applications like zdump(8) because pledge(2) doesn't allow access(2) to
/usr/share/zoneinfo.
millert@ better described why this call can go away:
"This looks like an attempt to do access checks based on the real uid instead
of the effective uid. Basically for setuid programs we don't want to allow a
user to set TZ to a path they should not be able to otherwise access.
However, we already have a check for issetugid() above so I think the doaccess
bits can just be removed and we can rely on open()."
After discussion with tb@, deraadt@ and millert@, this was also OK'ed by them
|
| |
|
|
|
|
|
|
| |
in libc's hidden/stdlib.h instead of in each .c file that needs one
ok deraadt@ gsoares@ mpi@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
void return types 'return no value'. This is obvious and therefore
unneccessary to mention.
We spare rewind(3)'s sentence because espie@ pointed out that it's a
warning - the function masks a potential error.
This commit also adds a sentence to X509_free clarifying that it's
NULL-safe. This bit was discussed with doug@.
ok martijn@, sentiment supported by schwarze@
|
| |
|
|
|
|
|
|
|
|
|
|
| |
don't want to change the current value"
it changes only the `request' argument behaviour when NULL is passed:
previously it was traited as "" was passed.
with help from jmc@ for man-page
OK tb@ on previous version
|
|
|
|
| |
ok millert@
|
|
|
|
| |
i've also changed some "and" to "no", since i think it reads better;
|
| |
|
| |
|
| |
|
|
|
|
| |
lots of agreement.
|
|
|
|
| |
Based on diff from Michal Mazurek (akfaew (at) jasminek.net)
|
|
|
|
|
|
| |
for generating and parsing them.
ok mpi@ naddy@ millert@ deraadt@
|
|
|
|
| |
From Michal Mazurek (akfaew (at) jasminek.net)
|
| |
|
| |
|
| |
|
|
|
|
| |
emulations left; ok millert@ deraadt@, jmc@ (man pages)
|
|
|
|
| |
ok mpi@
|
|
|
|
| |
that setting errno is required by POSIX, but not by ISO C.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is unambiguously required both by POSIX and by our own manual page.
It also makes a lot of sense because having a function that can
fail and that sets errno in some failure modes but does not set
errno in other failure modes would be a terrible idea. Such a
function would be ridiculously complicated to use. To detect the
reason for failure, you would have to:
- save errno
- reset errno to zero
- call the function
- inspect the return value to detect failure
- inspect errno to decide about the reason for failure
- if errno is zero, restore the saved errno
That is completely unreasonable, in particular for a seemingly innocous
function like mbtowc(3). Next to no programmer would get that right in
any real-world program.
Note that this bug is very widespread, it also affects NetBSD,
FreeBSD, Solaris 11, and glibc. I will also send a note around to
the other systems.
There may be fallout from programs using the interface incorrectly.
If you run into any, please report that to me.
OK millert@
|
|
|
|
| |
OK tb@
|
|
|
|
|
| |
about which options are turned on/off by 's' and 'S'
ok tedu
|
|
|
|
| |
ok jca@ gilles@
|
|
|
|
| |
from Rafael Neves; input jmc@; OK deraadt@
|
|
|
|
|
| |
/dev/console so the value of "error" is never read. Also mention
that sendsyslog2 can fail due to ENOBUFS in the comment. OK deraadt@
|
| |
|
|
|
|
|
| |
This function doesn't even have an "n" argument, so that non-existent
argument clearly cannot restrict the return value.
|
|
|
|
| |
Input and OK jmc@ ratchov@ semarie@
|
| |
|
| |
|
|
|
|
|
|
| |
incomplete characters are not an error, do not throw EILSEQ, and
are not supposed to.
OK millert@
|
| |
|
|
|
|
| |
improvements sthen@, jmc@. okay millert@, jca@ jmc@
|
|
|
|
|
|
| |
There is long-standing consensus that err(1, NULL) is the best idiom
after failure of malloc(3) and friends.
Quirk in the manual noticed by tb@.
|
|
|
|
| |
ok tobias@
|