| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
From Michael Forney, thanks!
|
|
|
|
|
|
| |
tested against openssl 1.1's server.
ok jsing@ tb@
|
|
|
|
|
|
| |
Needed for doing TLS 1.3 Post Handshake Handshake messages.
ok jsing@
|
|
|
|
| |
so that the regress tests will work for them
|
|
|
|
| |
ok beck@
|
|
|
|
|
|
| |
issues and makes call sites cleaner.
ok beck@
|
|
|
|
|
|
| |
rather than the hash of an empty context
ok jsing@
|
|
|
|
|
|
|
| |
For now ssl3_shutdown() is called in all cases, however TLSv1.3 will soon
get its own version.
ok beck@
|
|
|
|
| |
ok beck, jsing
|
|
|
|
|
|
| |
is complete, which should never occur.
ok beck@
|
|
|
|
|
|
| |
Discussed at length with beck@
ok beck@ tb@
|
| |
|
| |
|
|
|
|
| |
ok beck@
|
| |
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
| |
from a tls 1.3 connection, for now.
ok jsing@
|
|
|
|
|
|
| |
from the record layer
ok jsing@
|
|
|
|
|
| |
I'll figure it out a bit later.
Found and diagnosed by inoguchi@
|
|
|
|
| |
ok tb@ inoguchi@
|
|
|
|
| |
OK kn@ tb@
|
|
|
|
| |
poison the context. ok and help jsing@ tb@
|
| |
|
|
|
|
| |
and symbol addition.
|
|
|
|
|
|
|
|
|
| |
The recent EC group cofactor change results in stricter validation,
which causes the EC_GROUP_set_generator() call to fail.
Issue reported and fix tested by rsadowski@
ok tb@
|
|
|
|
|
|
|
|
|
| |
Among other improvements:
* Use a uniform wording at the top of the DECSRIPTION for obsolete pages.
* Better explain how to use a non-standard configuration file.
* Remove obsolete functions from SEE ALSO.
Triggered by some suggestions from tb@.
Tweaks and OK tb@.
|
| |
|
|
|
|
|
|
| |
Split some excessively long lists into useful sub-categories.
Add a new, very short subsection "Obsolete functions" at the end.
OK tb@ jmc@
|
| |
|
|
|
|
| |
ok tb@, jsing@, sthen@
|
|
|
|
|
|
|
|
|
|
|
| |
The RFC does not require X25519 and it also allows clients to send an empty
key share when the want the server to select a group. The current behaviour
results in handshake failures where the client supports TLS 1.3 and sends a
TLS key share extension that does not contain X25519.
Issue reported by Hubert Kario via github.
ok tb@
|
|
|
|
|
|
|
|
| |
name (which means the client sent SNI during the initial handshake).
Issue reported by Renaud Allard.
ok tb@
|
| |
|
|
|
|
|
|
|
|
|
| |
functions based on message type (clienthello/serverhello), to which side
is handling the processing.
No intended functional change.
ok beck@
|
| |
|
|
|
|
|
|
|
| |
no need to check for it. Fixes COV-165788, identified with help from Alex
Bumstead.
ok jsing@
|
|
|
|
|
|
| |
Fixes COV-174858
ok tb@
|
|
|
|
|
|
|
|
|
|
| |
it is an encrypted extension. Include it in the server hello for now.
This will have to be revisited once TLSv1.3 gets there. Fixes SRTP
negotiation.
Problem found by two rust-openssl regress failures reported by mikeb.
with & ok beck
|
|
|
|
|
|
| |
The decrypted session ticket contains key material.
ok tb@
|
|
|
|
|
|
|
|
|
| |
allocating on stack.
While here also check the return values from EVP_DecryptInit_ex() and
HMAC_Init_ex().
ok tb@
|
|
|
|
|
|
|
|
|
| |
Rename mlen to hlen since it is a hmac (and this matches hctx and hmac).
Rename ctx to cctx since it is a cipher context and ctx is usually used to
mean SSL_CTX in this code.
ok tb@
|
|
|
|
|
|
| |
This removes various pointer arithmetic and manual length checks.
ok tb@
|
|
|
|
|
|
| |
This handles the ret = 2 case and makes the code more readable.
ok tb@
|
|
|
|
|
|
|
|
|
| |
Convert ssl_get_prev_session(), tls1_process_ticket() and
tls1_decrypt_ticket() to handle the session ID from the client hello
as a CBS. While here also swap the order of arguments for
tls1_decrypt_ticket() so that it is consistent with the other functions.
ok tb@
|
|
|
|
|
|
|
| |
There is not much point having a tlsext_tick_md macro that replaces
EVP_sha256() in two places, when the cipher is just hardcoded.
ok tb@
|
|
|
|
|
|
|
|
| |
We only have to find one extension, so do that first then proceed with
processing and decryption. This makes the code more readable and drops
two levels of indent.
ok tb@
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the malloc() check and EVP_DecryptUpdate() - the malloc() failure
is fatal while a EVP_DecryptUpdate() is a decryption failure.
Also ensure that we clear the error stack in all cases where we are
indicating a failure to decrypt or decode the ticket - otherwise
SSL_error() while later return failure when it should not.
ok tb@
|
|
|
|
|
|
|
|
|
| |
Rather than returning from multiple places and trying to clean up as we go,
move to a single exit point and clean/free in one place. Also invert the
logic that handles NULL sessions - fail early, rather than having an
indented if test for success.
ok tb@
|
|
|
|
|
|
|
|
| |
In the case that X509_NAME_dup() succeeds, but sk_X509_NAME_push()
fails, name is leaked. The entire function is trying to be clever
and therefore hard to follow. Let's do it the stupid but safe way.
ok jsing
|
|
|
|
|
|
|
| |
SSL_CTX_add_extra_chain_cert(3).
From Dr. Stephen Henson <steve at openssl dot org>
via OpenSSL commit a4339ea3 Jan 3 22:38:03 2014 +0000
which is still under a free license.
|