summaryrefslogtreecommitdiffstats
path: root/sys/dev/usb/if_url.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Make some USB ioctls return ENXIO, instead of EIO, if usbd_is_dying().stsp2018-10-021-2/+2
| | | | | | | Brings us one step closer towards making this condition's error code consistent across all USB drivers. Patch by Moritz Buhl ok mpi@ bluhm@
* Use LIST_FOREACH construct instead of homebrew loop.kevlo2018-07-031-3/+2
| | | | ok bluhm@, mpi@
* move counting if_opackets next to counting if_obytes in if_enqueue.dlg2017-01-221-3/+1
| | | | | | | this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it. ok mpi@ deraadt@
* Avoid calling usbd_set_config_no() in *_attach() and let the stack dompi2016-11-061-9/+2
| | | | | | | | | it instead. If anything bad happen due to a malformed descriptor it makes no sense to try to attach a driver, and bail before probing. This is similar to the change to avoid calling usbd_set_config_index().
* G/C IFQ_SET_READY().mpi2016-04-131-3/+1
|
* replace IFF_OACTIVE manipulation with mpsafe operations.dlg2015-11-251-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue is now protected by a mutex. this diff makes the oactive functionality mpsafe too. IFF_OACTIVE is part of if_flags. there are two problems with that. firstly, if_flags is a short and we dont have any MI atomic operations to manipulate a short. secondly, while we could make the IFF_OACTIVE operates mpsafe, all changes to other flags would have to be made safe at the same time, otherwise a read-modify-write cycle on their updates could clobber the oactive change. instead, this moves the oactive mark into struct ifqueue and provides an API for changing it. there's ifq_set_oactive, ifq_clr_oactive, and ifq_is_oactive. these are modelled on ifsq_set_oactive, ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd. this diff includes changes to all the drivers manipulating IFF_OACTIVE to now use the ifsq_{set,clr_is}_oactive API too. ok kettenis@ mpi@ jmatthew@ deraadt@
* You only need <net/if_dl.h> if you're using LLADDR() or a sockaddr_dl.mpi2015-11-241-2/+1
|
* shuffle struct ifqueue so in flight mbufs are protected by a mutex.dlg2015-11-201-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the code is refactored so the IFQ macros call newly implemented ifq functions. the ifq code is split so each discipline (priq and hfsc in our case) is an opaque set of operations that the common ifq code can call. the common code does the locking, accounting (ifq_len manipulation), and freeing of the mbuf if the disciplines enqueue function rejects it. theyre kind of like bufqs in the block layer with their fifo and nscan disciplines. the new api also supports atomic switching of disciplines at runtime. the hfsc setup in pf_ioctl.c has been tweaked to build a complete hfsc_if structure which it attaches to the send queue in a single operation, rather than attaching to the interface up front and building up a list of queues. the send queue is now mutexed, which raises the expectation that packets can be enqueued or purged on one cpu while another cpu is dequeueing them in a driver for transmission. a lot of drivers use IFQ_POLL to peek at an mbuf and attempt to fit it on the ring before committing to it with a later IFQ_DEQUEUE operation. if the mbuf gets freed in between the POLL and DEQUEUE operations, fireworks will ensue. to avoid this, the ifq api introduces ifq_deq_begin, ifq_deq_rollback, and ifq_deq_commit. ifq_deq_begin allows a driver to take the ifq mutex and get a reference to the mbuf they wish to try and tx. if there's space, they can ifq_deq_commit it to remove the mbuf and release the mutex. if there's no space, ifq_deq_rollback simply releases the mutex. this api was developed to make updating the drivers using IFQ_POLL easy, instead of having to do significant semantic changes to avoid POLL that we cannot test on all the hardware. the common code has been tested pretty hard, and all the driver modifications are straightforward except for de(4). if that breaks it can be dealt with later. ok mpi@ jmatthew@
* arp_ifinit() is no longer needed.mpi2015-10-251-4/+1
|
* Increment if_ipackets in if_input().mpi2015-06-241-2/+1
| | | | | | | Note that pseudo-drivers not using if_input() are not affected by this conversion. ok mikeb@, kettenis@, claudio@, dlg@
* simply do if_input() between splnet() and splx(), like other driversuaa2015-03-271-6/+4
| | | | | | (such as if_udav.c). ok by mpi@
* Remove some includes include-what-you-use claims don'tjsg2015-03-141-2/+1
| | | | | | | have any direct symbols used. Tested for indirect use by compiling amd64/i386/sparc64 kernels. ok tedu@ deraadt@
* Convert to if_input().mpi2015-02-121-8/+4
| | | | ok dlg@
* unifdef INETtedu2014-12-221-3/+1
|
* No need for <netinet/in_systm.h> here.mpi2014-07-131-5/+1
|
* Kill a bunch of DVACT_DEACTIVATE handlers whose only purpose were tompi2014-07-121-33/+9
| | | | | | | | | | | | | | set the 'dying' flag of a device. Such handlers are useless now that usbd_detach() already set this flag. Even if the purpose of this flag is questionnable on OpenBSD because DVACT_DEACTIVATE acts as a pre-detach event, this is just a first small step towards the simplification of the autoconf(9) device states. This cleaning is now possible thanks to the work of pirofti@ to convert all the USB drivers to properly use usbd_is_dying(). Discussed many times with deraadt@
* Clean-up usbd_abort_pipe() usage.pirofti2013-11-151-13/+4
| | | | | | | This function never fails. So change it's return type to void and adjust the copy-pasted callers that were checking the return. "If it compiles, ok" mpi@
* Most network drivers include netinet/in_var.h, but apparently theybluhm2013-08-071-2/+1
| | | | | don't have to. Just remove these include lines. Compiled on amd64 i386 sparc64; OK henning@ mikeb@
* Get rid of various 'typedef struct' definitions and use plain structuremglocker2013-04-151-7/+7
| | | | | | | | | definitions instead. We don't change usb.h for now to stay compatible with userland. Tested by mpi@ on macppc and myself on i386. ok mpi@
* proc.h is way too much header for usb to handle.tedu2013-03-281-2/+1
|
* Rewrite the receive filter handling code and cleanup the ioctl bits.brad2013-01-291-80/+49
| | | | ok sthen@
* Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thingmatthew2011-07-031-4/+1
| | | | | | | | that's ever used it, and it's long since been changed to use DVACT_{QUIESCE,SUSPEND,RESUME} instead. ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it up a few weeks ago
* a bit more ansi; ok teduderaadt2011-06-231-7/+1
|
* garbage collect "usb events". without /dev/usb there is no way to accessjakemsr2011-01-251-6/+1
| | | | | | them from userland, and nothing in the kernel uses them. ok krw@, miod@
* * replace per-driver dying and/or other state variables with use ofjakemsr2010-12-061-45/+22
| | | | | | | usbd_deactivete() and usbd_is_dying() * use usbd_deactivate() in activate()/DEACTIVATE * convert a few more direct checks of the associated bus' dying flag with usbd_is_dying()
* don't free network related resources if they were not allocatedjakemsr2010-10-271-3/+5
|
* check that a timeout(9) has been initialized before deleting itjakemsr2010-10-231-2/+3
| | | | ok phessler
* create another kthread to run xfer abort tasks. xfer abort tasks cannotjakemsr2010-10-231-3/+5
| | | | | | | | | | | be run from the generic task kthread, because xfers that need to be aborted block newly queued tasks from running (i.e. the xfer to be aborted blocks the abort of that task). as there are now three types of usb tasks, add an argument to usb_init_task() and another member to struct usb_task to specify the task type. fixes boot hangs that are showing up because we now use usb tasks to attach/detach usb devices.
* Delete comments about these drivers needing powerhook support; they don't.deraadt2010-08-271-2/+1
|
* Get rid of devact enum, substitute it with an int and coresponding defines.pirofti2009-10-131-3/+3
| | | | | | This is needed for the addition of further suspend/resume actions. Okay deraadt@, marco@.
* Eliminate the redundant bits of code for MTU and multicast handlingbrad2008-11-281-19/+8
| | | | | | | | | | | | | | from the individual drivers now that ether_ioctl() handles this. Shrinks the i386 kernels by.. RAMDISK - 2176 bytes RAMDISKB - 1504 bytes RAMDISKC - 736 bytes Tested by naddy@/okan@/sthen@/brad@/todd@/jmc@ and lots of users. Build tested on almost all archs by todd@/brad@ ok naddy@
* Set the IFCAP_VLAN_MTU capabilities flag so these interfaces are allowedbrad2008-11-061-1/+3
| | | | to transmit full sized VLAN tagged frames.
* Use ether_ioctl().brad2008-10-031-4/+2
|
* Convert timeout_add() calls using multiples of hz to timeout_add_sec()blambert2008-09-101-3/+3
| | | | | | | Really just the low-hanging fruit of (hopefully) forthcoming timeout conversions. ok art@, krw@
* Sanitize the use of timeouts:mbalmer2007-11-231-6/+2
| | | | | | | | | | | | Instead of calling timeout_set(..., NULL, NULL) in attach routines and later timeout_del(...) timeout_set(..., func, arg) timeout_add(..., time) set the function and argument in the initial timeout_set() call and only use timeout_add(..., time) later. ok dlg, fgsch, krw, winiger
* treat usb vendor/product names as a locator, and have usbd_print handle it,deraadt2007-10-111-6/+1
| | | | | | so that it shows up before the :. as a result, all the usb devices do not need to have name printing code anymore. all this now works and prints nicely because usbd_probe_and_attach() is serialized. ok kettenis
* Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS andmbalmer2007-06-141-2/+17
| | | | | | | | USB_DECLARE_DRIVER macros. No binary change. ok dlg.
* Remove the definition and usage of the IF_INPUT macro which was definedmbalmer2007-06-131-2/+2
| | | | | | | | as ether_input_mbuf which is itself a macro for ether_input. No binary change. ok dlg.
* Remove the definition and use of the device_ptr_t which was a struct device *.mbalmer2007-06-121-10/+10
| | | | | | No binary change. ok mk.
* Remove the definition and usage of the USBGETSOFTC macro, which was reallymbalmer2007-06-111-6/+6
| | | | | | only a cast to (void *). ok jsg.
* Remove the definition and use of the USBDEVNAME macro.mbalmer2007-06-101-73/+73
| | | | | | | (This might look easy, but it was a big diff. Thanks to dlg and especially jsg for looking over it; we found at least four mistakes in the initial diff.) ok jsg.
* Remove the definition and use of the USBDEV macro. It only created confusionmbalmer2007-06-101-11/+11
| | | | | | | | and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev. No binary changes. ok jsg.
* Remove definitions and usage of usb_callout and related macros. These macrosmbalmer2007-06-101-6/+10
| | | | | | | | were used as a layer of confusion^Wabstraction around the timeout(9) API. No binary change. ok jsg.
* Remove the definition and use of if_deactivate(). It was defined empty andmbalmer2007-06-091-2/+1
| | | | | | | | thus produced no code at all. No binary change. ok jsg.
* Remove the "Static" declaration of many functions. It was defined to be emptymbalmer2007-06-051-65/+65
| | | | | | | and it was not consistently used. It was confusing as it suggested these functions were static, which they were not. discussed with dlg and jsg, ok jsg.
* Last part of FreeBSD/NetBSD sepcific code removal.mbalmer2007-06-041-23/+1
| | | | ok jsg@
* Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.jsg2007-05-271-11/+13
| | | | ok deraadt@ krw@ mbalmer@
* Remove logprintf macrojsg2007-05-211-3/+3
|
* Remove Ether_ifattach macrojsg2007-05-211-2/+2
|
* More lockmgr -> rwlock low hanging fruit.krw2007-05-061-5/+5
| | | | ok dlg@