| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gathered from usb devices.
Cache them early in usbd_new_device() instead of querying the device
several times (the content wont change anyway) and uselessly generating
usb traffic (which could conflict with other access..)
The heuristic stays the same, first look in the device descriptor, then
try to match against usb_known_vendors/usb_known_products, then fallback
to use the idVendor/idProduct codes.
Remove the now useless 'usedev' parameter from usbd_fill_deviceinfo().
Tested from bsd & bsd.rd.
suggested by and ok mpi@
|
|
|
|
|
|
| |
shorten and simplify code.
No intentional functional change.
|
|
|
|
|
|
|
|
|
|
|
|
| |
UFI command sets. Probe all the LUNs a device reports instead of
assuming ATAPI and UFI devices always have 1 LUN.
Motivated by the device David Vasek reported as claiming to be
ATAPI but wanting to use >1 LUN. Committing quickly to smoke out
the inevitable device that works in the exact opposite way. All
hail USB.
ok kettenis@
|
|
|
|
| |
Based on a diff from Mathieu <naabed AT poolp DOT org>.
|
|
|
|
|
|
|
| |
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.
ok tedu@ deraadt@
|
| |
|
|
|
|
| |
Okay mpi@
|
|
|
|
| |
ok guenther
|
|
|
|
|
|
| |
is causing problems when trying to boot sparc64 from an isp(4).
Verified to fix the sparc64/isp(4) regression by krw@; ok deraadt@
|
|
|
|
|
|
|
| |
SCSI_NO_ADAPTER_TARGET instead of a two target bus with a reserved
"host" target.
ok krw@
|
|
|
|
|
|
| |
saa_luns instead of adapter_buswidth and luns in the prototype link.
ok dlg@, miod@
|
|
|
|
|
|
|
| |
ATAPI devices. atapiscsi(4) is only for handling ATAPI devices on an
ATA bus, so umass(4) shouldn't care about it.
ok krw@, dlg@; no objections from deraadt@
|
|
|
|
|
|
|
| |
the USB serial number so as to limit the overall devid to just 20
characters.
"Lovely!" deraadt@
|
|
|
|
|
|
| |
from a USB serial number, as recommended by the umass spec.
ok dlg@
|
|
|
|
|
|
| |
it up by using the usb devices iSerial thing.
ok deraadt@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in time, which is a problem if your umass device has multiple luns
on it. if multiple commands are issued at the same time then they
step on some shared state, which in turn causes some interesting
panics.
this diff introduces an iopool in umass so only one command can be
"allocated" and scheduled at a time.
found, reproduced and investigated by krw@
fix verified by krw@
ok matthew@ krw@
|
|
|
|
|
|
|
|
| |
step in elminating 'struct scsi_device' entirely.
Spotted and initial diff from matthew@.
ok matthew@ dlg@ deraadt@ marco@ miod@
|
|
|
|
|
|
|
| |
low-hanging splbio/splx pairs that are no longer needed and see if
this reveals any hidden scsi flaws.
ok dlg@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
void. Use XS_NO_CCB error in the scsi command (xs) to report the
NO_CCB condition. Eliminates all SUCCESSFULLY_QUEUED and COMPLETE
confusion and untangles the midlayer from the adapter a bit more.
Eyes and some fixes by miod@
There may be some compile issues on little used (i.e. I don't have
any) drivers but the change is mechanical and thus easy to remedy.
ok dlg@
|
|
|
|
|
|
|
| |
POLL'ed command returned a SENSE error. Found on claudio's USB
stick which doesn't like SYNCH CACHE commands.
ok dlg@
|
|
|
|
|
|
|
| |
else cares so it's just noise. Drivers that actually look at ITSDONE
are unchanged.
ok marco@ (for his files) dlg@ beck@
|
|
|
|
|
|
|
|
|
| |
that returning COMPLETE for non-SCSI_POLL commands is significant.
Fixes double free of xs and subsequent crashes caused by pulling
out USB media while i/o is active. Problem analyzed & fix discovered
by hshoexer@. A more general fix may follow post-4.6.
ok miod@ deraadt@.
|
|
|
|
|
|
| |
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.
|
|
|
|
|
|
|
|
|
| |
Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.
OK deraadt@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
debug output shows the xs/command before it's issued rather than
displaying it on command completion. Some commands don't come back
and it would be nice to see their details.
While here nuke invocations of scsi_show* in umass. If you want SCSI
debug output use SCSI debug options.
Only affects SCSI debug output.
ok marco@
|
|
|
|
|
|
| |
there is another splbio()/splx and a check for ITSDONE before falling
into the COMPLETE case. So just return COMPLETE if the command has
completed (or never started). Simpler all around.
|
|
|
|
| |
'totally OK' deraadt@
|
|
|
|
|
| |
allocated memory, as I can't see an obvious initialization of the
memory elsewhere. NetBSD uses M_ZERO here.
|
|
|
|
|
|
| |
No binary change.
ok dlg.
|
|
|
|
|
|
|
| |
(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)
ok jsg.
|
|
|
|
|
|
|
|
| |
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.
No binary changes.
ok jsg.
|
| |
|
|
|
|
| |
ok miod@ marco@ deraadt@
|
|
|
|
|
| |
defined to be 0. Expunge references. Null entries in quirks table will be
removed later.
|
|
|
|
|
|
|
|
|
|
|
|
| |
padded 12 byte commands mandated by the standard. Adapt the Linux data
length twiddling on certain commands. We used to have some of this in
a different form, curtesy of csapuntz@, but it got lost in subsequent
merges.
Fixes the USB card reader of Quentin Barnes who provided much testing
and feedback for over a year!
Tested by drahn@, ok marco@, 'this is good stuff' deraadt@.
|
|
|
|
|
|
|
|
|
|
| |
full LUN scan on UMASS SCSI targets. UMASS provides reliable max lun
information so we shouldn't waste time. Fixes many x-in-1 card
reader/writers that report identical INQUIRY information for every
slot they provide.
Lots of diagnosis and testing by dlg@, ok dlg@, 'I can live with this'
marco@.
|
|
|
|
|
|
| |
seen at reboot time after writing to umass devices.
ok dlg@, testing markus@
|
|
|
|
| |
ok krw@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
log message for umass 1.98, umass_scsipi.c 1.11, umassvar.h 1.21:
Fix several problems with CCI handling, and enable it: * We were never calling
the callback function when we got a UFI CCI(!). * We were passing a bogus
residual count on non-UFI CCIs. * After a REQUEST SENSE, the UFI CCI may
include the ASC/ASCQ from the sense information -- don't consider this a
failure.
In addition, remove a horrible hack that was causing us to drop sense
information on the floor and return empty INQUIRY responses, often in the
case where there is a UNIT ATTENTION pending during the INQUIRY. (Some drives
send the data and then fail, some don't.)
log message for umass.c 1.113:
Do not return STATUS_WIRE_FAILED in response to a CBI stall. This is perfectly
normal, and is used to report errors. Instead, use STATUS_CMD_FAILED, which
causes us to do a REQUEST SENSE. Should address PR 22960.
log message for umass.c 1.115:
Do not do a CBI reset before returning STATUS_CMD_FAILED. This causes any
sense information to be thrown away, and is therefore nonsensical.
ok krw@
|
|
|
|
|
|
|
| |
UMASS_QUIRK_FORCE_SHORT_INQUIRY. Fixes a bunch of USB devices. Based
on work by Mycroft in NetBSD.
ok tdeval@ deraadt@.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
moreluns field in scsi_link structure. Instead, treat an INQUIRY
result that duplicates the INQUIRY result of LUN 0 as proof the LUN
does not exist. Compensate for lack of SDEV_NOLUNS where necessary by
setting sc_link->luns to 1, which has the same effect. From Marco
Peereboom.
Don't issue Test Unit Ready command before INQUIRY command - not
necessary and potentially harmful to devices with ADEV_NOTUR quirk
since quirks have not been set yet. From mycroft@NetBSD
ok deraadt@, mvme* changes by miod@.
|
|
|
|
| |
ok nate@
|
|
|
|
|
|
| |
failed.
ok nate@.
|
|
|
|
| |
with our scsi layer
|
| |
|
|
|