| Age | Commit message (Collapse) | Author | Files | Lines |
|
Stop manipulating the done list and root hub port status in the interrupt
handler.
Some parts lifted from NetBSD's r1.157 but with functionnal polling and
without leaving WDH interrupts masked after exiting ddb(4).
Fix an splassert() by no longer calling usb_transfer_complete() in the
interrupt handler.
Issue reported by claudio@, brynet@ and Jacqueline Jolicoeur.
|
|
variants.
ok jsg@, deraadt@
|
|
when calling in_ioctl(). These ioctls modify the routing table,
which is global. So they need the lock.
Found with Zaur Molotnikov's static lock analyzer.
OK gerhard@ mpi@
|
|
|
|
USB is the last real user of IPL_SOFTNET.
|
|
use it.
Instead of defering every input of a USB console keyboard to a timeout
via a queue of one element, only differ entering ddb(4) once a matching
control sequenece has been typed.
This prevent loosing inputs when a USB console keyboard is "too fast".
Fix a problem reported by matthieu@, Adam McDougall and Hrvoje Popovski.
ok stsp@, dlg@
|
|
might free it.
Prevent a use-after-free in various aynchronous cases. Found while
looking at another user-after-free pointed out by ehrhardt@.
Committing now to find if other drivers rely on this use-after-free.
tb@ confirmed ubcmtp(4) is now fixed.
|
|
noop and prevent us from fixing real use-after-free.
Since xfer->status is reset by *_device_intr_done(), checking for
USBD_IOERROR cannot be true.
Problem reported by tb@ because ubcmtp(4) triggers some I/O errors
when multiple fingers are used.
|
|
ok mpi@
|
|
the driver needs to enable the CCK high power feature, as already done for
other chips supported by urtwn(4).
Same change as FreeBSD r311347.
Patch submitted by Kevin Lo. Tested by me.
|
|
mpi says a transfer can't exist without a pipe. ok mpi@
|
|
MBIM already uses network byte order for IP addresses, so just
use them as they are.
ok stsp@, deraadt@
|
|
Bombardieri" <mb@ii.net>.
|
|
Using a name with the 'db_' prefix makes it invisible from the dynamic
profiler.
ok deraadt@, kettenis@, visa@
|
|
From Hiltjo Posthuma.
|
|
tested by bluhm@, ststp@ and Bryan Vyhmeister.
ok bluhm@ ststp@
|
|
from Brad
|
|
constants.
The consensus is that if both operands are constant, we don't need
mallocarray. Reminded by tedu@
ok deraadt@
|
|
ok deraadt@
|
|
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.
|
|
extra zero'ing of variables not needed because softc is pre-zero'd.
ok jsg
|
|
|
|
them, but for release let's be conservative and use 0.
|
|
the received packet fits in a single mbuf cluster, which isn't necessarily
the case. This might fix the pool corruption seen by jcs@.
ok jcs@, jmatthew@, deraadt@
|
|
that are now covered by the generic class matching.
|
|
0 "No class specific protocol required" in addition to the existing
protocol 1 "AT Commands: V.250 etc" match.
This lets umodem(4) attach to the serial console on the overdrive 1000
which is a usb type-b socket on the back of the box not a db9 like the
overdrive 3000.
|
|
ok natano visa
|
|
|
|
certainly doing the same.
So revert r1.85 for the moment, we're too close from the release and
these bugs have been there for years.
Regression reported by tb@ on bugs@
|
|
Special thanks to Martina P. for her help.
ok jcs@ jung@
|
|
to the FreeBSD driver.
This driver will attach instead of cdce(4), which doesn't expose a PHY and
doesn't work with my 5c20 revision of the chip.
ok jimatthew@, jcs@
|
|
By setting "machdep.forceukbd=1" you can now use your USB keyboard in
ddb(4) even if your BIOS emulates a pckbd(4).
ok tom@, kettenis@, deraadt@
|
|
*_root_ctrl_start() routines are synchronous and all end up calling
usb_transfer_complete() in the non-error case. After calling this
function it is unsafe to dereference ``xfer'' since the transfer
callback has been called. So returning USBD_IN_PROGRESS is wrong in
this case since transfers are always completed at this point.
So return USBD_NORMAL_COMPLETION or the corresponding error code if
something wrong happen.
|
|
This code contains a use-after-free which be addressed in an upcoming
diff.
This fix xhci(4) polling mode.
ok kettenis@
|
|
This flag should only be set by the stack, drivers shouldn't
mess with it.
Discussed with dlg@ and mikeb@, ok gerhard@
|
|
From Christian Ludwig.
|
|
might free it.
Prevent a use-after-free in various aynchronous cases. Found while
looking at another user-after-free pointed out by ehrhardt@.
|
|
OK stsp@
|
|
Spotted by stsp@; OK jmatthew@
|
|
OK stsp@
|
|
runs the mailbox interface knows about a MAC address that appears to be
derived from a unique serial number along with the raspberry pi
foundation oui.
It modifies the device tree when booting to store the MAC address
in /axi/usb/hub/ethernet/mac-address so fetch and use this value
for the integrated smsc(4) Ethernet.
A different smsc adapter plugged into one of the USB ports
probes later with a different unit number and skips this path.
|
|
Thanks.
|
|
code. From Michael W. Bombardieri" <mb at ii.net>. Thanks.
|
|
ok visa@
|
|
Found by LLVM/Clang Static Analyzer.
ok mpi@
|
|
From Michael Reed
|
|
Fixes 'usbd_do_request: not in process context' warnings introduced recently.
Fix reported and confirmed by Mikhail aka mp39590 aka misha
|
|
Fix stolen from Linux commit 9ed04d976146cf10dfa4c71171434af7c0348747
ok visa@
|
|
this means packets are consistently counted in one place, unlike the
many and various ways that drivers thought they should do it.
ok mpi@ deraadt@
|
|
The heavy lifting was done by damien@ years ago. I didn't even have
to figure out what the hardware expects, the code was already there.
This driver now supports MCS 0-15 in client and hostap mode.
No Tx aggregation and no 40 MHz channels yet.
tested by vgross@, bmercer@, tb@, jmc@, Vadim Vygonets, Peter Kay
ok bmercer@ tb@ phessler@
|